Skip to content

CDK: Destinations: Backport CDK fixes for redshift #40499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 1, 2024
Merged

CDK: Destinations: Backport CDK fixes for redshift #40499

merged 11 commits into from
Jul 1, 2024

Conversation

@edgao
Copy link
Contributor

@edgao edgao commented Jun 25, 2024 •
edited
Loading

This is branched from b88a41d (merge commit for #39460, i.e. cdk 0.38.2).

  • add a flag to disable SQL statement logging (needed to avoid logging out S3 creds in our COPY command)
  • add support in JdbcSqlGenerator for generation ID

test plan:

release plan:

  • merge master, release a new CDK version (0.40.4), merge this PR
    • i.e. CDK 0.39.x won't include this fix, which I think is OK

backported publish versions:

@vercel
Copy link

vercel bot commented Jun 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2024 8:04pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jun 25, 2024
@edgao edgao marked this pull request as ready for review June 25, 2024 18:05
@edgao edgao requested review from a team as code owners June 25, 2024 18:05
@edgao
Copy link
Contributor Author

edgao commented Jun 25, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/9668880906
✅ Successfully published Java CDK version=0.38.3!

@edgao edgao force-pushed the edgao/java_cdk_backport_0_38_2 branch from 7902cb1 to 6cc46f7 Compare June 25, 2024 22:11
@edgao
Copy link
Contributor Author

edgao commented Jun 25, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/9670292973
❌ Publish Java CDK version=0.35.16 failed!

@edgao edgao force-pushed the edgao/java_cdk_backport_0_38_2 branch from 6cc46f7 to 7902cb1 Compare June 25, 2024 22:33
@edgao edgao mentioned this pull request Jun 25, 2024
Merged
@edgao edgao mentioned this pull request Jun 27, 2024
Merged
@edgao
Copy link
Contributor Author

edgao commented Jun 27, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk --force=true

Error: Unexpected inputs provided: ["--force"]

@edgao
Copy link
Contributor Author

edgao commented Jun 27, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk force=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/9699402050
✅ Successfully published Java CDK version=0.38.3!

@edgao
Copy link
Contributor Author

edgao commented Jun 27, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk force=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/9699966304
✅ Successfully published Java CDK version=0.38.3!

@edgao
Merge branch 'master' into edgao/java_cdk_backport_0_38_2
32fb83f 
# Conflicts:
#	airbyte-cdk/java/airbyte-cdk/README.md
#	airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties
@edgao
Copy link
Contributor Author

edgao commented Jul 1, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/9750102511

edgao added 2 commits July 1, 2024 12:59
@edgao
Merge branch 'master' into edgao/java_cdk_backport_0_38_2
800f1d6 
# Conflicts:
#	airbyte-cdk/java/airbyte-cdk/README.md
#	airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties
@edgao
better changelog
3147f35
@edgao
Copy link
Contributor Author

edgao commented Jul 1, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/9750311207
✅ Successfully published Java CDK version=0.40.8!

@edgao edgao merged commit 779d363 into master Jul 1, 2024
@edgao edgao deleted the edgao/java_cdk_backport_0_38_2 branch July 1, 2024 20:26
xiaohansong pushed a commit that referenced this pull request Jul 9, 2024
@edgao @xiaohansong
CDK: Destinations: Backport CDK fixes for redshift (#40499)
ef4d48d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stephane-airbyte stephane-airbyte stephane-airbyte approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CDK Connector Development Kit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edgao @stephane-airbyte @octavia-squidington-iii