Skip to content

postgres source/destination - bump postgres driver version #39460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
evantahler merged 13 commits into from
Jun 14, 2024
Merged

postgres source/destination - bump postgres driver version #39460

evantahler merged 13 commits into from
Jun 14, 2024

Conversation

@evantahler
Copy link
Contributor

@evantahler evantahler commented Jun 13, 2024

@vercel
Copy link

vercel bot commented Jun 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2024 7:22pm

evantahler
evantahler commented Jun 13, 2024
View reviewed changes
airbyte-cdk/java/airbyte-cdk/datastore-postgres/build.gradle
implementation project(':airbyte-cdk:java:airbyte-cdk:airbyte-cdk-core')

api 'org.postgresql:postgresql:42.6.0'
api 'org.postgresql:postgresql:42.6.2'
Copy link
Contributor Author

@evantahler evantahler Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change - everything else is just plumbing

@evantahler evantahler marked this pull request as ready for review June 13, 2024 16:35
@evantahler evantahler requested review from a team as code owners June 13, 2024 16:35
stephane-airbyte
stephane-airbyte suggested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@stephane-airbyte stephane-airbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also should bump the version in deps.toml

@evantahler
Copy link
Contributor Author

evantahler commented Jun 13, 2024

Looks like PostgresDestinationHandler needs to implement createNamespaces - I need help with that

@gisripa
Copy link
Contributor

gisripa commented Jun 13, 2024

Looks like PostgresDestinationHandler needs to implement createNamespaces - I need help with that

@evantahler I merged the kotlin conversion today morning which took care of that. (empty impl for now until new interfaces kick in).

@evantahler
Copy link
Contributor Author

evantahler commented Jun 13, 2024 •
edited
Loading

New plan - the postgres destination(s) can't use the latest CDK until the Airbyte 1.0 work is complete (ERROR: column "_airbyte_generation_id" of relation "users_final" does not exist). So, in this PR I'll bump the CDK dependencies + source, and when we update the postgres destination in general later this month, it will gain the new JDBC driver.

@evantahler
Copy link
Contributor Author

evantahler commented Jun 13, 2024

@xiaohansong - any tips about what I should be doing here to get source-postgres to build with the latest CDK?

Error: [Task :airbyte-integrations:connectors:source-postgres:compileJava] constructor RelationalDbDebeziumPropertiesManager in class RelationalDbDebeziumPropertiesManager cannot be applied to given types;
    final var propertiesManager = new RelationalDbDebeziumPropertiesManager(

@theyueli
Copy link
Contributor

theyueli commented Jun 14, 2024

@xiaohansong - any tips about what I should be doing here to get source-postgres to build with the latest CDK?

Error: [Task :airbyte-integrations:connectors:source-postgres:compileJava] constructor RelationalDbDebeziumPropertiesManager in class RelationalDbDebeziumPropertiesManager cannot be applied to given types;
    final var propertiesManager = new RelationalDbDebeziumPropertiesManager(

Is this actually related to @akashkulk 's change? The constructor now requires a new parameter:

https://github.com/airbytehq/airbyte/pull/39405/files#diff-3af961ccd56f952a3f466eb2f94fb6786785e37aa298fc1134e1aec2d2f81869R22

@xiaohansong
Copy link
Contributor

xiaohansong commented Jun 14, 2024

@akashkulk has a fix in #39474

@evantahler
Copy link
Contributor Author

evantahler commented Jun 14, 2024

After rebasing the latest from @akashkulk, this PR is green!
Can I please get a review from @airbytehq/dbsources

xiaohansong
xiaohansong reviewed Jun 14, 2024
View reviewed changes
@evantahler
Copy link
Contributor Author

evantahler commented Jun 14, 2024 •
edited by github-actions bot
Loading

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/9521245332
✅ Successfully published Java CDK version=0.38.2!

@evantahler evantahler enabled auto-merge (squash) June 14, 2024 19:21
@evantahler evantahler merged commit b88a41d into master Jun 14, 2024
@evantahler evantahler deleted the evan/postgres-driver-bump branch June 14, 2024 19:35
@edgao edgao mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@xiaohansong xiaohansong xiaohansong approved these changes

@stephane-airbyte stephane-airbyte stephane-airbyte approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/postgres

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@evantahler @gisripa @theyueli @xiaohansong @stephane-airbyte @octavia-squidington-iii