Skip to content

Conversation

@edgao
Copy link
Contributor

@edgao edgao commented Jun 21, 2024

  • upgrade cdk to the next breakpoint (includes gen_id/sync_id, and adds plumbing for stream statuses, but doesn't yet include any actual refreshes logic)
  • also: includes the better defaultNamespace handling / stream status plumbing from the CDK bump

ran two syncs in the perf test workspace with this version; verified that the tables got generation_id correctly

closes https://github.com/airbytehq/airbyte-internal-issues/issues/8358

@vercel
Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 7:48pm

@edgao edgao changed the title Destination Redshift: Add generation_id Destination Redshift: Add generation_id and sync_id Jun 21, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jun 21, 2024
Copy link
Contributor Author

edgao commented Jun 21, 2024

@edgao edgao force-pushed the edgao/redshift_generation_id branch 3 times, most recently from 5eea8ad to a07ab6e Compare June 24, 2024 16:24
@edgao edgao force-pushed the edgao/redshift_new_interfaces branch from 1c20def to 1750b55 Compare June 25, 2024 17:56
@edgao edgao force-pushed the edgao/redshift_generation_id branch from a07ab6e to da81fd0 Compare June 25, 2024 17:57
@edgao edgao force-pushed the edgao/redshift_new_interfaces branch from 1750b55 to 2f51fd9 Compare June 25, 2024 22:58
@edgao edgao force-pushed the edgao/redshift_generation_id branch from da81fd0 to 8a0951e Compare June 25, 2024 22:58
@edgao edgao force-pushed the edgao/redshift_new_interfaces branch 4 times, most recently from b22f4d9 to 4d34b0a Compare June 26, 2024 22:34
@edgao edgao force-pushed the edgao/redshift_generation_id branch from 8a0951e to ddf5940 Compare June 26, 2024 22:35
@edgao edgao force-pushed the edgao/redshift_generation_id branch from ddf5940 to d84dd36 Compare June 26, 2024 23:49
@edgao edgao force-pushed the edgao/redshift_new_interfaces branch from 4d34b0a to 0254987 Compare June 26, 2024 23:58
@edgao edgao force-pushed the edgao/redshift_generation_id branch from d84dd36 to af94f4d Compare June 26, 2024 23:58
Base automatically changed from edgao/redshift_new_interfaces to master June 27, 2024 14:52
@edgao edgao force-pushed the edgao/redshift_generation_id branch 2 times, most recently from 9c7b93d to 4398a4b Compare June 27, 2024 14:59
@edgao edgao force-pushed the edgao/redshift_generation_id branch 7 times, most recently from 9b5a05f to a17ab12 Compare June 27, 2024 22:28
@edgao edgao marked this pull request as ready for review June 27, 2024 22:28
@edgao edgao requested a review from a team as a code owner June 27, 2024 22:28
@edgao edgao force-pushed the edgao/redshift_generation_id branch 4 times, most recently from 5edb758 to cf3e408 Compare July 1, 2024 15:03
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 1, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use transaction.joinToString("\n") instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log.error(e) {...}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/redshift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants