Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python support 3.8.0 #533

Closed
vir-mir opened this issue Jan 28, 2019 · 4 comments
Closed

Fix python support 3.8.0 #533

vir-mir opened this issue Jan 28, 2019 · 4 comments
Labels
bug

Comments

@vir-mir
Copy link
Member

vir-mir commented Jan 28, 2019

The problem with passing tests.
python version 3.8.0a0 https://travis-ci.com/aio-libs/aiohttp/jobs/173498419
@aio-libs-bot
Copy link

GitMate.io thinks possibly related issues are #508 (Deprecated async lock with Python 3.7), #436 (Python 3.7 compatibility), #136 (Update async generators protocol to support Python 3.5.2/3.6+), #105 (Why is only ISOLATION_LEVEL_READ_COMMITTED supported?), and #58 (PostgreSQL notification support).

@vir-mir vir-mir added the bug label Jan 28, 2019
vir-mir pushed a commit that referenced this issue Jan 28, 2019
interim fix due to issues #533
70d280f
@vir-mir vir-mir mentioned this issue Jan 28, 2019
Closed
vir-mir pushed a commit that referenced this issue Jan 28, 2019
interim fix due to issues #533
b76222a
@gjcarneiro
Copy link
Contributor

From the traceback it seems like a pyflakes bug? In any case, Python 3.8 is still a long time away. It seems premature to be testing it already. At least wait for beta.

@vir-mir
Copy link
Member Author

vir-mir commented Feb 1, 2019 •
edited
Loading

From the traceback it seems like a pyflakes bug? In any case, Python 3.8 is still a long time away. It seems premature to be testing it already. At least wait for beta.

Yes, but travis-ci, python 3.8.dev was given over the link nightly
In PR, I made the section nightly optional https://github.com/aio-libs/aiopg/pull/534/files#diff-354f30a63fb0907d4ad57269548329e3R42

vir-mir added a commit that referenced this issue Sep 23, 2019
@vir-mir
release 1.0.0 (#592)
ea9c039 
* modification in tests

* removing obsolete examples

* removing old style (yield from) in docs

* rename psycopg2 to psycopg2-binary in docs

* added note in docs about going to python3.5.2+

* interim fix due to issues #533

* add docs example and style

* add isort and deleted obsolete non-asynchronous cursor iteration

* fix async iter for python 3.5

* add readthedocs.yml

* travis allow failures python:nightly

* travis allow failures python:nightly

* travis allow failures python:nightly

* travis allow failures python:nightly

* travis remove docker cache

* fix code style yml

* refactor

* fix docs

* normalized version c to rc pep440

* edit docs

* refactor sa connection

* fix travis

* fix travis

* fix travis

* fix test

* Update aiopg/cursor.py

Co-Authored-By: Boryslav Larin <[email protected]>

* Update docs/one_cursor.rst

Co-Authored-By: Boryslav Larin <[email protected]>

* Update .readthedocs.yml

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>

* Update CONTRIBUTING.rst

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>

* Update CONTRIBUTING.rst

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>

* Update CONTRIBUTING.rst

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>

* Update CONTRIBUTING.rst

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>

* Update CONTRIBUTING.rst

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>

* Update CONTRIBUTING.rst

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>

* Update CONTRIBUTING.rst

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>

* Update CONTRIBUTING.rst

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>

* Update CONTRIBUTING.rst

Co-Authored-By: Sviatoslav Sydorenko <[email protected]>

* remove mogrify

* add changes

* python 3.8 and update requirements

* python 3.8 and update requirements

* python 3.8 and update requirements
@Pliner
Copy link
Member

Pliner commented Dec 4, 2020

It looks like this issues it outdated(python 3.8 support is added to the CI #754)

@Pliner Pliner closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Pliner @gjcarneiro @vir-mir @aio-libs-bot