Bump psycorg and sqlalchemy, add python 3.8, 3.9 to test matrix #754
Conversation
Pliner
changed the title
Codecov Report
@@ Coverage Diff @@
## master #754 +/- ##
==========================================
+ Coverage 92.47% 92.64% +0.16%
==========================================
Files 13 13
Lines 1489 1563 +74
Branches 176 179 +3
==========================================
+ Hits 1377 1448 +71
- Misses 79 82 +3
Partials 33 33
Continue to review full report at Codecov.
|
Pliner
force-pushed
the
bump-psycorg-and-sqlalchemy
branch
from
68df8da to
7a67b5d
Compare
| @@ -56,7 +55,7 @@ async def test_pool_context_manager_timeout(pg_params, loop): | |||
| async with aiopg.create_pool(**pg_params, minsize=1, | |||
| maxsize=1) as pool: | |||
| cursor_ctx = await pool.cursor() | |||
| with pytest.raises(psycopg2.ProgrammingError): | |||
| with pytest.warns(ResourceWarning): | |||
There was a problem hiding this comment.
@asvetlov I'm pretty unsure about this, but it looks like this behaviour has changed because of psycorg update to 2.8+. Do you have any thoughts about this?
There was a problem hiding this comment.
I don't monitor psycopg2 changelist but this line looks good to me if the test passes.
There was a problem hiding this comment.
Cool, thanks.
PS I had tried to figure out why it could happened from change log, but failed to do so 😢
Pliner
force-pushed
the
bump-psycorg-and-sqlalchemy
branch
from
7a67b5d to
b5ff78e
Compare
Min supported version of psycorg is 2.8.4 because of python 3.8