-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project edits for pr517 #534
Conversation
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
=========================================
+ Coverage 94.35% 94.6% +0.25%
=========================================
Files 27 27
Lines 3740 3728 -12
Branches 171 169 -2
=========================================
- Hits 3529 3527 -2
+ Misses 179 164 -15
- Partials 32 37 +5
Continue to review full report at Codecov.
|
5f32af7
to
b76222a
Compare
In the next release notes, besides saying it requires async/await, there should probably be a note about dropping of the deprecated non-asynchronous iterator protocol ( So this works: async for row in cursor: ... This used to work, but was already deprecated, and no longer works: for row in cursor: ... There was already a deprecation warning: https://github.com/aio-libs/aiopg/blob/v0.16.0/aiopg/cursor.py#L384-L387 |
@gjcarneiro thx, this is a good point! |
@popravich if you review at this PR, I would be grateful |
@asvetlov @popravich You are noted in the documentation support here https://readthedocs.org/projects/aiopg/ The question is, are the hooks configured to build the master and the tags? I watch the last build was a long time ago. https://readthedocs.org/projects/aiopg/builds/ |
Thanks for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing this is PITA. Maybe you could split it into atomic chunks?
Co-Authored-By: Boryslav Larin <[email protected]>
Co-Authored-By: Boryslav Larin <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
This pull request introduces 3 alerts when merging a72f3ac into 82f3ced - view on LGTM.com new alerts:
|
in master |
@asvetlov @jettify since the changes are not compatible with previous versions, I propose to upgrade to major version
1.0.0