Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project edits for pr517 #534

Closed
wants to merge 40 commits into from
Closed

Project edits for pr517 #534

wants to merge 40 commits into from

Conversation

vir-mir
Copy link
Member

@vir-mir vir-mir commented Jan 28, 2019

  • Modification in tests
  • Removing old style file examples
  • Removing old style (yield from) in docs
  • Rename psycopg2 to psycopg2-binary in docs
  • added note in docs about going to python3.5.2+
  • Interim fix due to issues Fix python support 3.8.0 #533
  • refactor docs style
  • aded the example code

@asvetlov @jettify since the changes are not compatible with previous versions, I propose to upgrade to major version 1.0.0

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #534 into master will increase coverage by 0.25%.
The diff coverage is 93%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #534      +/-   ##
=========================================
+ Coverage   94.35%   94.6%   +0.25%     
=========================================
  Files          27      27              
  Lines        3740    3728      -12     
  Branches      171     169       -2     
=========================================
- Hits         3529    3527       -2     
+ Misses        179     164      -15     
- Partials       32      37       +5
Impacted Files Coverage Δ
tests/test_async_transaction.py 100% <ø> (ø)
aiopg/log.py 100% <ø> (ø) ⬆️
tests/test_sa_priority_name.py 100% <ø> (ø)
tests/test_sa_engine.py 98.92% <100%> (ø) ⬆️
aiopg/pool.py 100% <100%> (ø) ⬆️
tests/test_sa_transaction.py 86.59% <100%> (ø) ⬆️
tests/test_connection.py 98.63% <100%> (ø) ⬆️
tests/test_sa_distil.py 100% <100%> (ø) ⬆️
tests/test_async_await.py 100% <100%> (ø)
tests/test_pool.py 100% <100%> (+0.24%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdf7b9...a72f3ac. Read the comment docs.

@gjcarneiro
Copy link
Contributor

gjcarneiro commented Jan 29, 2019

In the next release notes, besides saying it requires async/await, there should probably be a note about dropping of the deprecated non-asynchronous iterator protocol (__iter__). Now only __aiter__ is available.

So this works:

async for row in cursor: ...

This used to work, but was already deprecated, and no longer works:

for row in cursor: ...

There was already a deprecation warning: https://github.com/aio-libs/aiopg/blob/v0.16.0/aiopg/cursor.py#L384-L387

@vir-mir
Copy link
Member Author

vir-mir commented Jan 30, 2019

@gjcarneiro thx, this is a good point!

@vir-mir
Copy link
Member Author

vir-mir commented Jan 30, 2019

@popravich if you review at this PR, I would be grateful

.readthedocs.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@vir-mir
Copy link
Member Author

vir-mir commented Feb 2, 2019

@asvetlov @popravich You are noted in the documentation support here https://readthedocs.org/projects/aiopg/

The question is, are the hooks configured to build the master and the tags? I watch the last build was a long time ago. https://readthedocs.org/projects/aiopg/builds/

@asvetlov
Copy link
Member

asvetlov commented Feb 2, 2019

Thanks for the PR.
What is your account on readthedocs?
I want to add you as the project admin

CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing this is PITA. Maybe you could split it into atomic chunks?

vir-mir and others added 12 commits September 20, 2019 13:21
Co-Authored-By: Boryslav Larin <[email protected]>
Co-Authored-By: Boryslav Larin <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2019

This pull request introduces 3 alerts when merging a72f3ac into 82f3ced - view on LGTM.com

new alerts:

  • 3 for Unreachable code

@vir-mir vir-mir mentioned this pull request Sep 20, 2019
@vir-mir
Copy link
Member Author

vir-mir commented Sep 23, 2019

in master

@vir-mir vir-mir closed this Sep 23, 2019
@vir-mir vir-mir deleted the project_edits_for_pr517 branch September 23, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants