-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Type Annotations to Py3 syntax #76
Comments
I guess that it would also be good to annotate pycares. |
For sure. But I feel that should be an issue over at https://github.com/saghul/pycares :) |
Did it: saghul/pycares#112 |
mimi89999
added a commit
to mimi89999/aiodns
that referenced
this issue
Dec 12, 2019
mimi89999
added a commit
to mimi89999/aiodns
that referenced
this issue
Dec 12, 2019
I opened a PR 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since this project is now >= Python 3.5 we can move all type annotations to Python 3 syntax except variable annotations (they will need to stay as comments until the project is >= 3.6).
Happy to do the PR one day and also happy if someone else beats me. I did PR #75 to add CI type checking, ensuring master is passing before we convert.
Not sure if there are tools to do this for us, but manual wouldn’t take to long.
The text was updated successfully, but these errors were encountered: