Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Type Annotations #112

Open
cooperlees opened this issue Dec 12, 2019 · 1 comment
Open

Add Type Annotations #112

cooperlees opened this issue Dec 12, 2019 · 1 comment

Comments

@cooperlees
Copy link

cooperlees commented Dec 12, 2019 •
edited
Loading

It would be nice to have the pycares code base was type annotated or stubbed. This will allow users to ensure they are always passing correct types and will probably find a subtle bug or two.

One example is aiodns has to disable checking pycares due to not type annotation when running mypy.
@cooperlees cooperlees mentioned this issue Dec 12, 2019
Closed
@saghul
Copy link
Owner

saghul commented Dec 12, 2019

I don't think I'll have the time or inclination to do this myself, but I will welcome a PR :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saghul @cooperlees