Add mypy to CI for cpython #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cooperlees
commented
Dec 12, 2019
cooperlees
commented
- Lets ensure we stay type awesome.
- Also fix all type errors with latest mypy - pycares seems to have no typing / stubs so lets ignore it via `mypy.ini`
This was referenced Dec 12, 2019
|
Looking good, thank you! |
mimi89999
reviewed
Dec 12, 2019
| @@ -75,21 +75,21 @@ def query(self, host, qtype): | |||
| qtype = query_type_map[qtype] | |||
| except KeyError: | |||
| raise ValueError('invalid query type: {}'.format(qtype)) | |||
| fut = asyncio.Future(loop=self.loop) | |||
| fut = asyncio.Future(loop=self.loop) # type: asyncio.Future | |||
There was a problem hiding this comment.
Actually mypy with the strict option reports Missing type parameters for generic type "Future". Indeed, nobody knows what will be returned when that future will be awaited.
There was a problem hiding this comment.
@cooperlees Sorry. Looks like futures can't be annotated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.