refactor!: remove network interfaces #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeberhard
approved these changes
Sep 14, 2023
Co-authored-by: Enrico Eberhard <[email protected]>
domire8
added a commit
that referenced
this pull request
Sep 20, 2023
Remove network interfaces library, python module and scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First part of a series of PRs where I'm removing the old network interfaces and fully replacing it with communication interfaces including python bindings.
As a first step, I removed the old libraries with its scripts and updated the Dockerfile.ci. Next steps include reshuffling the files a bit, adding python bindings and update the CI including the removal of develop branch.
Review guidelines
Estimated Time of Review: 10 minutes
Checklist before merging: