CI: Increase cleanup job timeout to 180 minutes - #1964
Conversation
|
👋 Hi ntsemah! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
/build |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Jenkins cleanup matrix configuration increases the ChangesCleanup job configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/ok to test 34ef52a |
|
/build |
|
/ok to test a311600 |
|
🤖 CI Triage Agent — TL;DR: The Full analysisSummary: Stage "Run Nixlbench tests" (build variant ucx-v1.22.x, node 299) failed — Root cause: In Implicated commit: [REDACTED:Hex High Entropy String] "Enable local xfer for UCCL backend (#1428)" — Pravein Govindan Kannan (introduced the local/loopback transfer path that shares a connection with the local agent). File: src/plugins/uccl/uccl_backend.cpp:42-55 (destructor connection-destroy loop; dedup keyed on Suggested fix: Dedup connection destruction by the actual connection pointer/id rather than the agent name — track destroyed Related: PRs #1428 (local xfer for UCCL), #1151 (UCCL consistency checks), #895 (initial UCCL backend). No existing issue found for this specific segfault.
|
Signed-off-by: Noam Tsemah <ntsemah@nvidia.com>
|
/build |
|
/ok to test 5f5539c |
|
🤖 CI Triage Agent — TL;DR: The v1.22.x "Run Nixlbench tests" stage was aborted (exit 143) after hanging ~18 minutes during shutdown of a UCCL-backend ETCD benchmark; the fix is to debug the UCCL engine/RDMA connection teardown hang — not to raise the cleanup timeout as PR #1964 proposes. Full analysisSummary: Root cause: A hang, not a slow test. The log shows continuous per-iteration output up to Implicated commit: unknown for the hang itself; the UCCL teardown path was last substantially touched by File: UCCL RDMA epoll client event loop — reported as Suggested fix: Investigate the UCCL engine shutdown path that runs after an RDMA connection HUP. The worker completes the transfer, prints Related: PR #1964 (the timeout-increase change under test) — #1964 ; UCCL history PRs #1428, #1271, #895.
|
|
🤖 CI Triage Agent — TL;DR: The Full analysisSummary: Root cause: In Implicated commit: Not a code regression from commit 71a8325 / PR #1964 (unrelated); the port-allocation logic dates to [REDACTED:Hex High Entropy String] (Alexey Rivkin, "CI: cap port pool below kernel ephemeral range", #1685) and earlier. Root cause is in CI infrastructure, not the PR under test. File: Suggested fix: First, re-run the build — this is a flaky port collision and the parallel Related: #1685 (port pool capping), #1081/#1294 (prior CPP test reliability tweaks); no existing issue matches this exact bind race — worth filing one.
|
…ing to release/1.4.0 (#1968) ## What Backports the wheel-build and CI infrastructure from `main` to `release/1.4.0` — six commits, cherry-picked in main's chronological order: 1. **#1870** — split `Dockerfile.manylinux` into `wheel_base`/`wheel` stages so CI caches the expensive deps image; adds `--wheel-base-image` to `build-container.sh` 2. **#1933** — auto-derive `CI_IMAGE_TAG` in `cidemo-init.sh` (matrix YAMLs carry a `CI_MANAGED` placeholder patched at CI time; no manual tag bumps) 3. **#1941** — `--build-infinia`: bundle the Infinia DDN plugin (`libplugin_INFINIA.so`) into the wheel (opt-in) 4. **#1918** — `--build-ucx-spcx-plugin`: build and bundle the UCX spcx external plugin (`libuct_ib_mlx5_ext.so`) into the wheel (opt-in) 5. **#1956** — rename `BUILD_TARGET` → `DOCKER_BUILD_TARGET` in `build-container.sh` (Jenkins exports a `BUILD_TARGET` job param that leaked into the docker command line) 6. **#1863** — add the per-PR container-build pipeline (`nixl-ci-build-container-pr`) and dispatcher fan-out After this PR, `Jenkinsfile.dispatcher`, `cidemo-init.sh`, `build-container.sh`, `Dockerfile.manylinux`, and `build-container-pr-matrix.yaml` are byte-identical to `main`. Conflict resolutions (all mechanical): - Matrix YAMLs: release-branch hardcoded `CI_IMAGE_TAG` values replaced by the `CI_MANAGED` placeholder (#1933) - `ci-overview.md`: kept release-accurate wording where main's text references features not backported (vLLM/SGLang sanity #1777, cleanup job #1785) Intentionally **not** backported (not needed for release CI): vLLM/SGLang sanity testing (#1777), Artifactory cleanup job (#1785, #1964), CI timeout right-sizing (#1932), LLM base image pins (#1893), port pool cap (#1685). ## Why Needed for the 1.4.0 release: internal wheels must bundle the UCX spcx and Infinia plugins, and the release-branch CI needs the same wheel-build pipeline as `main` to build them. Both plugin features are opt-in (off by default); default builds are byte-identical to the current release branch. --------- Signed-off-by: Nir Wolfson <nwolfer@nvidia.com> Signed-off-by: NirWolfer <nwolfer@nvidia.com> Co-authored-by: Alexey Rivkin <57558538+Alexey-Rivkin@users.noreply.github.com>
What?
Increase cleanup job timeout to 180 minutes
Why?
Job runs daily and currently takes ~55 min. Raised the
limit to handle growth in artifacts so the job does not
time out before finishing cleanup.
How?
It is optional, but for complex PRs, please provide information about the design,
architecture, approach, etc.
Summary by CodeRabbit