Fix UCCL's consistency checks - #1151
Merged
Merged
Conversation
Signed-off-by: Pravein Govindan Kannan <pravein.govindan.kannan@ibm.com>
Signed-off-by: Pravein Govindan Kannan <pravein.govindan.kannan@ibm.com>
Signed-off-by: Pravein Govindan Kannan <pravein.govindan.kannan@ibm.com>
|
👋 Hi praveingk! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
|
/ok to test 9f0ab11 |
Contributor
|
/build |
brminich
reviewed
Dec 23, 2025
Contributor
|
i see this failure, which may be related. Checking if the CI node is healthy |
Contributor
Author
By any chance is it an AWS EFA node? Wondering why |
Signed-off-by: Pravein Govindan Kannan <pravein.govindan.kannan@ibm.com>
Signed-off-by: Pravein Govindan Kannan <pravein.govindan.kannan@ibm.com>
Contributor
|
/ok to test 353baf0 |
Contributor
|
/build |
Contributor
Author
|
@brminich Recently experimental EFA feature was pushed in UCCL. Probably, here it's hitting that on the AWS nodes. Can you please confirm if it's AWS nodes, and it was used previously? If so, I will need to turn off the EFA feature. |
Contributor
|
@praveingk, no it is not AWS node. It is x86 with 1 h100 gpu and 1 BF3 NIC |
Contributor
|
can you open this link https://nbuprod.blsm.nvidia.com/nbu-swx-nixl-main/blue/rest/organizations/jenkins/pipelines/nixl-ci-gpu/runs/108/nodes/199/log/?start=0? it contains some debug info including |
This was referenced May 6, 2026
This was referenced Jun 30, 2026
This was referenced Jul 8, 2026
This was referenced Jul 15, 2026
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix consistency check of UCCL
How?
UCCL backend was using the base address instead of the specific local/remote address during batches. This PR fixes that address and keeps multiple FIFO items for the batches instead of the single one used per handle.
A fix was also added to UCCL to enable memory check based on its range.