Repository navigation
fix: prevent pkill etcd from killing other containers' processes - #1227
Merged
Merged
Conversation
Replace `pkill etcd` with targeted process termination using captured PID. When running multiple test containers in parallel (e.g., SLURM enroot), `pkill etcd` would kill etcd processes across all containers, causing the second container to fail with exit code 1. Changes: - Capture etcd PID immediately after backgrounding: ETCD_PID=$! - Replace `pkill etcd` with `kill -9 $ETCD_PID 2>/dev/null || true` - Use SIGKILL (-9) for immediate, reliable termination in test environment - Add error suppression to prevent script failure if process already exited This ensures each container only terminates its own etcd instance, allowing parallel test execution without interference. Signed-off-by: Daniel Pressler <danielpr@nvidia.com>
|
👋 Hi dpressle! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
Author
|
/build |
ovidiusm
approved these changes
Jan 19, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Ensures each container only terminates its own etcd instance, allowing parallel test execution without interference.
Why?
When running multiple test containers in parallel (e.g., SLURM enroot),
pkill etcdwould kill etcd processes across all containers, causing the second container to fail with exit code 1.How?
Replace
pkill etcdwith targeted process termination using captured PID.Changes:
pkill etcdwithkill -9 $ETCD_PID 2>/dev/null || true