Skip to content

fix: prevent pkill etcd from killing other containers' processes #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpressle merged 1 commit into from
Jan 19, 2026
Merged

fix: prevent pkill etcd from killing other containers' processes #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitlab/test_cpp.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ export NIXL_ETCD_NAMESPACE="/nixl/cpp_ci/${etcd_port}"
etcd --listen-client-urls ${NIXL_ETCD_ENDPOINTS} --advertise-client-urls ${NIXL_ETCD_ENDPOINTS} \
--listen-peer-urls ${NIXL_ETCD_PEER_URLS} --initial-advertise-peer-urls ${NIXL_ETCD_PEER_URLS} \
--initial-cluster default=${NIXL_ETCD_PEER_URLS} &
ETCD_PID=$!

wait_for_etcd

Expand Down Expand Up @@ -129,4 +130,4 @@ echo "./bin/p2p_test disabled"
echo "./bin/ucx_worker_test disabled"
echo "${TEXT_CLEAR}"

pkill etcd
kill -9 $ETCD_PID 2>/dev/null || true
3 changes: 2 additions & 1 deletion .gitlab/test_nixlbench.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export NIXL_ETCD_NAMESPACE="/nixl/nixlbench_ci/${etcd_port}"
etcd --listen-client-urls ${NIXL_ETCD_ENDPOINTS} --advertise-client-urls ${NIXL_ETCD_ENDPOINTS} \
--listen-peer-urls ${NIXL_ETCD_PEER_URLS} --initial-advertise-peer-urls ${NIXL_ETCD_PEER_URLS} \
--initial-cluster default=${NIXL_ETCD_PEER_URLS} &
ETCD_PID=$!

wait_for_etcd

Expand Down Expand Up @@ -116,4 +117,4 @@ if $HAS_GPU ; then
done
fi

pkill etcd
kill -9 $ETCD_PID 2>/dev/null || true
3 changes: 2 additions & 1 deletion .gitlab/test_python.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ export NIXL_ETCD_NAMESPACE="/nixl/python_ci/${etcd_port}"
etcd --listen-client-urls ${NIXL_ETCD_ENDPOINTS} --advertise-client-urls ${NIXL_ETCD_ENDPOINTS} \
--listen-peer-urls ${NIXL_ETCD_PEER_URLS} --initial-advertise-peer-urls ${NIXL_ETCD_PEER_URLS} \
--initial-cluster default=${NIXL_ETCD_PEER_URLS} &
ETCD_PID=$!

wait_for_etcd

Expand Down Expand Up @@ -125,4 +126,4 @@ telePID=$!
sleep 15
kill -s INT $telePID

pkill etcd
kill -9 $ETCD_PID 2>/dev/null || true