Repository navigation
Conversation
Guard preparation (NIXL init + pool registration) no longer blocks the claim response; promotion waits for it instead, and the Guard core startup budget defaults to 30 s and can be raised with `--startup-timeout-seconds` (`KVCRConfig.startup_timeout_seconds`). Cores released during registration are kept and closed once registered; a release never waits. Preparation failure remains service-fatal. Host pools are registered pinned by default: the quick-start image no longer sets `UCX_REG_NONBLOCK_MEM_TYPES`, and the dev-guide explains why ODP is not recommended. With ODP, registering a 50 GiB pool failed intermittently with EBUSY under memory compaction; without it, the first registration of a 150 GiB Guard pool takes 12–19 s on an 8-CPU sidecar, more than the claim path could absorb. Signed-off-by: Kapil Arya <kapila@nvidia.com>
Observe Unix accept-loop and Guard actor progress without claiming pools. Add an optional HTTP companion check, shutdown cleanup, CLI validation and focused tests. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
aranadive
marked this pull request as ready for review
October 26, 2026 03:53
copy-pr-bot
Bot
force-pushed
the
pull-request/116
branch
from
October 26, 2026 17:34
95b3cb2 to
19f8d9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional, read-only HTTP health probes to the standalone KVCR service so deployments can observe service and Guard progress without claiming pools or changing leases.
Stacked on #116: this draft targets
pull-request/116, the upstream copy of PR 116 at95b3cb2. The review diff contains only the health-probe commit (614b1f8). After #116 merges, rebase as needed and retarget this PR tomain; do not merge into the temporary base branch.Companion deployment draft: ai-dynamo/dynamo#17290.
Changes
GET /liveand/readywith--health-port; bind to loopback by default. Both return 503 on known failures, shutdown, or stalled Unix accept/Guard actor loops.Validation
ruff check src testsandruff format --check src tests: passed.tests/unitsuite against the rebased source in the qualified Linux/NIXL container: 649 passed. A separate host-native run had four failures, including NIXL backend/FlexIO errors; the container run is the passing reference.