Repository navigation
feat(service): add optional read-only health probes - #125
Merged
Merged
Conversation
Observe Unix accept-loop and Guard actor progress without claiming pools. Add an optional HTTP companion check, shutdown cleanup, CLI validation and focused tests. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
aranadive
marked this pull request as ready for review
October 26, 2026 20:35
Return 503 for HTTP protocol errors and malformed dependency ports. Extend the existing dependency test with a malformed status line and reuse the service CLI argument helper. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Reject malformed dependency URL syntax, missing hosts, and invalid ports during argument parsing before pool allocation. Extend the existing invalid-options table with an invalid IPv6 URL. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Expose health probes before pool allocation. Keep promotion waits and companion dependencies readiness-only, while reporting startup and shutdown explicitly. Cover the CLI lifecycle with functional tests and reuse promotion coverage for lease preservation. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
Return 503 for URL encoding and redirect parsing failures. Extend the existing HTTP test and clarify that readiness aggregates all Guards. Signed-off-by: Adit Ranadive <aranadive@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional, read-only HTTP health probes to the KVCR service so deployments can gate startup and detect failures without claiming pools or changing leases.
Behavior
--health-portenables/liveand/readybefore pool allocation. During allocation,/livereturns 200 and/readyreturns 503; known failures and shutdown fail both.--health-hostcontrols the listener address;--health-timeout-secondssets the progress deadline.--health-dependency-urloptionally requires a companion HTTP endpoint to return 200 for/readyonly./ready, not/live; stalled Guard progress also affects only readiness.The probes do not require an attached engine or establish inference readiness. Deployments must coordinate service/pool replacement with affected engines; restarting only the Guard sidecar is unsafe.
Companion deployment: ai-dynamo/dynamo#17290.