chore(container): bump tensorrt-llm pin from 1.3.0rc11 to 1.3.0rc13 - #8870
chore(container): bump tensorrt-llm pin from 1.3.0rc11 to 1.3.0rc13#8870yifjiang wants to merge 1 commit into
Conversation
The current pip_wheel pin in container/context.yaml is tensorrt-llm==1.3.0rc11 (tagged 2026-04-07). The C++ admission-overflow fix for issue NVIDIA/TensorRT-LLM#13318 (PR NVIDIA/TensorRT-LLM#12976, "Fix compute token accounting for KV cache reuse with context chunking") merged to TRT-LLM main on 2026-04-18. Tag-by-tag status, verified by checking the cherry-picked microBatchScheduler.cpp on each tag tree: - v1.3.0rc11 (2026-04-07, 4e69c14f7): reuse_adjusted_compute count = 0 -- does NOT include the admission fix. - v1.3.0rc12 (2026-04-16, 61cef212a): reuse_adjusted_compute count = 0 -- does NOT include the admission fix (rc12 was cut 2 days before PR ai-dynamo#12976 merged). - v1.3.0rc13 (2026-04-26, b9ce4b69d): reuse_adjusted_compute count = 10 (1 static helper + 9 call sites) -- this is the first published rc tag with the admission fix. Bumping rc11 -> rc13 directly (skipping rc12) gives users of dynamo's default container path (has_trtllm_context: "0") the upstream fix for issue NVIDIA/TensorRT-LLM#13318 without forcing them onto a custom-built wheel. Files updated: - container/context.yaml: pip_wheel and github_trtllm_commit - container/deps/requirements.common.txt: comment that documents the transformers version constraint per backend (rc11 -> rc13; same ==4.57.3 constraint applies, no transformers pin change needed) - docs/reference/support-matrix.md: "main (ToT)" row TRT-LLM column (the historical "v1.1.0-dev.3" row stays at rc11 because that release shipped against rc11 -- that is a fact about the past) docs/reference/release-artifacts.md is intentionally NOT changed: every rc11 reference in that file is in the v1.1.0-dev.3 release-history section (lines 169 / 587 / 594), which describes what that past release shipped. Those are historical facts. Verified locally: - ARM64 (GB200) container build with this change pulls tensorrt-llm==1.3.0rc13 from pypi.nvidia.com without conflict. - Static cross-check: libtensorrt_llm.so in the resulting venv has the reuse_adjusted_compute static helper compiled in (rc13 source tree has 10 occurrences; the helper is optimizer-inlined so strings-grep returns 0, but provenance is established via byte-identity of the shipped library against the rc13 wheel build). Signed-off-by: Yifan Jiang <19356972+yifjiang@users.noreply.github.com>
E2E test on the rc13-built image — doneBuilt Setup
VerificationSmoke testcurl -X POST http://<node>:8088/v1/chat/completions \
-H 'Content-Type: application/json' \
-d '{"model":"Qwen3-4B","messages":[{"role":"user","content":"Say hello in one word."}],"max_tokens":12}'
# → 200 OK, content "<think>\nOkay, the user asked me to say hello in"Sustained-load run (issue #13318 trigger phase)Decoder-log diagnostics
For comparison: an Test plan boxes
|
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR has been closed due to inactivity. If you believe this PR is still relevant, please feel free to reopen it with additional context or information. |
Summary
Bump the default
tensorrt-llmPyPI pin incontainer/context.yamlfrom1.3.0rc11(tagged 2026-04-07) to1.3.0rc13(tagged 2026-04-26). rc13 is the first published release tag that includes NVIDIA/TensorRT-LLM#12976 ("Fix compute token accounting for KV cache reuse with context chunking"), the C++ admission fix for NVIDIA/TensorRT-LLM#13318.Tag-by-tag verification
Verified by checking
cpp/tensorrt_llm/batch_manager/microBatchScheduler.cppon each tag tree:reuse_adjusted_computecountv1.3.0rc11(4e69c14f7)v1.3.0rc12(61cef212a)v1.3.0rc13(b9ce4b69d)So rc11 → rc13 is the smallest possible jump that brings in the upstream fix. rc12 is intentionally skipped — it does not include the fix.
Why this matters
Without the C++ admission fix, dynamo + TRT-LLM under workloads that combine
enable_chunked_prefill: true,enable_block_reuse: true, and tightmax_num_tokenscan hit:(reproducible on rc11 with Qwen3-4B / GB200 + multi-turn-chat replay at qps≥12; for the same workload, an image built with the rc13 wheel does not crash). The bug is C++-side: chunked-prefill non-first-chunk admissions were over-admitted relative to
max_num_tokensbecause the scheduler did not subtract the discounted reuse cost correctly. PR #12976 fixes the math at admission time.Files changed
container/context.yaml—pip_wheel: tensorrt-llm==1.3.0rc11→rc13andgithub_trtllm_commit: v1.3.0rc11→v1.3.0rc13(the second key drives the URL we curlinstall_tensorrt.shfrom incontainer/templates/trtllm_framework.Dockerfile:129).container/deps/requirements.common.txt— comment-only update on thetransformersconstraint line (rc11 → rc13; same==4.57.3constraint applies, no actualtransformerspin change).docs/reference/support-matrix.md— bump the**main (ToT)**row's TRT-LLM column from1.3.0rc11→1.3.0rc13. The historicalv1.1.0-dev.3row stays at1.3.0rc11because that release shipped with rc11 — that is a fact about the past.docs/reference/release-artifacts.mdis intentionally not changed: every1.3.0rc11reference in that file is in thev1.1.0-dev.3release-history section (lines 169 / 587 / 594), describing what that past release shipped — historical, not ToT.Verification done locally
tensorrt-llm==1.3.0rc13frompypi.nvidia.comcleanly.has_trtllm_context: "0"path; no custom wheel.libtensorrt_llm.somatches the rc13 release wheel (provenance confirms fix(container): make vLLM FlashInfer cubin dirs writable (#12770) #12976's C++ admission fix is compiled in; the helper isstaticand inlined by the optimizer so symbol-grep is unreliable, but byte-identity against the rc13 wheel establishes presence).Test plan
trtllm-pipeline(covers TRT-LLM container-build + smoke test against rc13)pre-commit(no Python changes; should be a no-op)dynamo-trtllmcontainer, run a known-good aggregated-serving smoke test on Qwen3-4B / 1× GB200, confirm/v1/chat/completionsreturns 200.max_num_tokens=4096) and confirm zeroAssertionError: total_num_tokens > max_num_tokensevents.Related
v1.3.0rc13release tag (2026-04-26)