Skip to content

ci(sidecar): build images in PR and nightly CI - #13601

Closed
nv-tusharma wants to merge 6 commits into
mainfrom
codex/sidecar-ci-builds
Closed

ci(sidecar): build images in PR and nightly CI#13601
nv-tusharma wants to merge 6 commits into
mainfrom
codex/sidecar-ci-builds

Conversation

@nv-tusharma

Copy link
Copy Markdown
Collaborator

Summary

  • add a reusable multi-architecture image build for the vLLM, SGLang, and TensorRT-LLM sidecars
  • run sidecar builds only for sidecar-changing PRs and nightly CI
  • publish immutable SHA tags, plus floating nightly tags, through the existing ECR builder path
  • route Docker Hub base images through the authenticated CI mirror while preserving local builds

Validation

  • node .github/scripts/test-filters.js (38/38 passed)
  • pre-commit commit hooks passed
  • workflow YAML and embedded build shell syntax validated
  • cargo metadata --locked confirms all three sidecar packages
  • container builds not run locally because the Docker daemon was unavailable; PR CI will exercise them

Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
@github-actions github-actions Bot added ci Issues/PRs that reference CI build/test documentation Improvements or additions to documentation actions labels Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
Comment thread .github/workflows/pr.yaml Fixed
Comment thread .github/workflows/pr.yaml Fixed
nv-tusharma and others added 3 commits August 20, 2026 11:25
Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
…ntain permissions'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
@nv-tusharma

Copy link
Copy Markdown
Collaborator Author

/ok to test 966cf0e

Signed-off-by: Tushar Sharma <tusharma@nvidia.com>
echo "dgdr: ${{ steps.filter.outputs.dgdr_any_modified }}"
echo "planner: ${{ steps.filter.outputs.planner_any_modified }}"
echo "sidecar: ${{ steps.filter.outputs.sidecar_any_modified }}"
echo "vllm_sidecar: ${{ steps.filter.outputs.vllm_sidecar_any_modified }}"
echo "planner: ${{ steps.filter.outputs.planner_any_modified }}"
echo "sidecar: ${{ steps.filter.outputs.sidecar_any_modified }}"
echo "vllm_sidecar: ${{ steps.filter.outputs.vllm_sidecar_any_modified }}"
echo "sglang_sidecar: ${{ steps.filter.outputs.sglang_sidecar_any_modified }}"
echo "sidecar: ${{ steps.filter.outputs.sidecar_any_modified }}"
echo "vllm_sidecar: ${{ steps.filter.outputs.vllm_sidecar_any_modified }}"
echo "sglang_sidecar: ${{ steps.filter.outputs.sglang_sidecar_any_modified }}"
echo "trtllm_sidecar: ${{ steps.filter.outputs.trtllm_sidecar_any_modified }}"
echo "dgdr: ${{ steps.filter.outputs.dgdr_all_modified_files }}"
echo "planner: ${{ steps.filter.outputs.planner_all_modified_files }}"
echo "sidecar: ${{ steps.filter.outputs.sidecar_all_modified_files }}"
echo "vllm_sidecar: ${{ steps.filter.outputs.vllm_sidecar_all_modified_files }}"
echo "planner: ${{ steps.filter.outputs.planner_all_modified_files }}"
echo "sidecar: ${{ steps.filter.outputs.sidecar_all_modified_files }}"
echo "vllm_sidecar: ${{ steps.filter.outputs.vllm_sidecar_all_modified_files }}"
echo "sglang_sidecar: ${{ steps.filter.outputs.sglang_sidecar_all_modified_files }}"
echo "sidecar: ${{ steps.filter.outputs.sidecar_all_modified_files }}"
echo "vllm_sidecar: ${{ steps.filter.outputs.vllm_sidecar_all_modified_files }}"
echo "sglang_sidecar: ${{ steps.filter.outputs.sglang_sidecar_all_modified_files }}"
echo "trtllm_sidecar: ${{ steps.filter.outputs.trtllm_sidecar_all_modified_files }}"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions ci Issues/PRs that reference CI build/test documentation Improvements or additions to documentation size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants