docs: fix dead links and anchors left by the docs path re-alignment - #13318
docs: fix dead links and anchors left by the docs path re-alignment#13318azrabano23 wants to merge 3 commits into
Conversation
- repoint mocker/DynoSim doc references to operations/simulation-with-dynosim/ (directory renamed in ai-dynamo#12373) - correct the generate-frontend-openapi output path in README.md and README.zh-CN.md (the binary writes docs/frontends/openapi.json) - fix recipe cross-references: qwen-3-8-2-4t-a95b-fp8 quickstart path and the kimi-k2.5 tokenspeed pointer to its TRT-LLM sibling recipe - retarget anchors whose headings were renamed: tests/README VRAM filtering, profiler-guide generated-DGD section, observability logging README - replace links to sections that no longer exist: planner manual-test prerequisites, recipes GAIE install guide, trtllm deploy client section Signed-off-by: Azra Bano <azrabano.work@gmail.com>
|
👋 Hi azrabano23! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (13)
WalkthroughThis change updates documentation links and anchors across project READMEs and guides. The links now reference current OpenAPI output, Kubernetes deployment and operations pages, simulation documentation, planner guidance, profiler sections, and recipe paths. ChangesDocumentation link updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change only repairs documentation links and anchors without altering product behavior; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
| ## Testing the Deployment | ||
|
|
||
| Send a test request to verify your deployment. See the [client section](../../../../docs/fern/pages/developer-guide/knowledge-base/modular-components/backends/vllm/overview.md#client) for detailed instructions. | ||
| Send a test request to verify your deployment. See the [Send a request step of the Kubernetes quickstart](../../../../docs/fern/pages/kubernetes/getting-started/quickstart.mdx#send-a-request) for detailed instructions. |
There was a problem hiding this comment.
The #send-a-request fragment targets a Step in quickstart.mdx that has no explicit id, so the anchor is not stable for Fern link checks. Fix: add id="send-a-request" to the target Step or remove the fragment.
🤖 AI Fix
In docs/fern/pages/kubernetes/getting-started/quickstart.mdx, change <Step title="Send a request"> to <Step title="Send a request" id="send-a-request"> so the link from examples/backends/trtllm/deploy/README.md resolves.
|
The failing lychee check is the pre-existing external 404s on xgrammar.mlc.ai in |
|
Adding a data point for this PR rather than opening a competing one, since it already covers dead links in both README files.
That link started failing Timing suggests why: #13269 promoted v1.4.0 to current release. The redirect declared in Checked from outside CI: So pointing the two READMEs straight at Happy to leave it entirely to you, or to send it as a separate commit if you would rather keep this PR's scope fixed. Not opening my own PR for it since it is the same two files and the same purpose as yours. |
Signed-off-by: Azra Bano <azrabano.work@gmail.com> # Conflicts: # lib/mocker/src/replay/offline/README.md
…nd-a-request step The kubernetes-deployment/start-here/installation-guide URL relies on a channel-specific redirect that the newly promoted latest channel does not carry (diagnosed by @ayaangazali on the PR); link the /latest/ page directly. Give the quickstart's 'Send a request' Step an explicit id so the fragment link added in this PR is stable. Signed-off-by: Azra Bano <azrabano.work@gmail.com>
|
Both follow-ups are in (a6a4b36):
Branch is also merged up to current main. |
Overview
Fixes 15 dead cross-references (13 files) left behind by the docs restructure and path re-alignment (#10855, #12243, #12373). Every link touched here pointed at a file, directory, or heading that no longer exists on
main; every replacement target was verified to exist. Related to the follow-up tracker #13278.What was broken
Renamed directory —
operations/dynosim/becameoperations/simulation-with-dynosim/in #12373, but four references still used the old path (404 on GitHub):lib/mocker/README.md(2 links)lib/mocker/src/replay/offline/README.mdcomponents/src/dynamo/mocker/README.md(this one's link text also displayed a pre-Fern path,docs/dynosim/mocker.md— updated to name the real destination)Doc contradicts code —
README.md/README.zh-CN.mdsaygenerate-frontend-openapiwrites todocs/reference/api/openapi.json; the binary hardcodesdocs/frontends/openapi.json(lib/llm/src/bin/generate_frontend_openapi.rs:63). Neitherdocs/reference/api/nor any committedopenapi.jsonexists.Wrong relative paths in recipes:
qwen-3-8-2-4t-a95b-fp8.mdxlinked../kubernetes/quickstart.mdx(nonexistent) instead of../../kubernetes/getting-started/quickstart.mdx, which every sibling recipe uses.recipes/kimi-k2.5/tokenspeed/agg/nvidia/README.mdpointed at../../trtllm/agg/nvidia/— wrong depth and wrong directory name. The description (TP=8, single DGD) matchesrecipes/kimi-k2.5/trtllm/agg-round-robin/(deploy.yamlsetstensor_parallel_size: 8).Anchors to renamed headings (no matching heading or
<Step>title in the target, so broken on both GitHub and the hosted site):tests/README.md:#filtering-by-vram→ the section is nowVRAM Markers and Filteringprofiler-guide.md:#generated-dgd-overrides→ the section is nowOptional: Customize the generated DGDdeploy/observability/logging/README.md:observability.mdx#logging→ no such heading; retargeted to#configure-structured-logs(and the link text displayed another pre-Fern path)Links to sections that no longer exist:
components/src/dynamo/planner/tests/manual/README.md:planner-guide.md#prerequisites— the guide has no Prerequisites section; dropped the dead fragmentrecipes/README.md:deploy/inference-gateway/README.md#2-deploy-inference-gateway— that README is now a stub with a single heading; retargeted to the Gateway API Inference Extension guide it defers toexamples/backends/trtllm/deploy/README.md:backends/vllm/overview.md#client— the vLLM overview has no client section (and linking trtllm users to vLLM docs was itself odd); retargeted to the Kubernetes quickstart's "Send a request" stepNotes
<Step title="...">components on the hosted site were deliberately left alone, even though GitHub's markdown view doesn't resolve them — only anchors with no matching heading or Step title anywhere in the target were treated as broken.Summary by CodeRabbit