feat: Add a "model" label to Component metrics #2383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anant Sharma <[email protected]> Co-authored-by: Ishan Dhanani <[email protected]>
Co-authored-by: Dmitry Tokarev <[email protected]>
Co-authored-by: Dmitry Tokarev <[email protected]>
Signed-off-by: Anish <[email protected]> Co-authored-by: Anish <[email protected]>
…2260) Signed-off-by: Biswa Panda <[email protected]>
…#2319) Signed-off-by: Anish <[email protected]> Co-authored-by: Kristen Kelleher <[email protected]> Co-authored-by: Biswa Panda <[email protected]> Co-authored-by: Neal Vaidya <[email protected]>
Signed-off-by: Anish <[email protected]>
Signed-off-by: Anish <[email protected]>
tzulingk
requested review from
a team,
hutm,
ishandhanani,
nealvaidya,
nnshah1 and
whoisj
as code owners
tzulingk
requested review from
GuanLuo,
PeaBrane,
alec-flowers,
biswapanda,
grahamking,
hhzhang16,
jthomson04,
julienmancuso,
kkranen,
mohammedabdulwahhab,
paulhendricks,
piotrm-nvidia,
ptarasiewiczNV,
richardhuo-nv,
rmccorm4,
ryanolson,
tanmayv25,
tedzhouhk and
tmonty12
as code owners
Contributor
|
The base isn't right here, there are many extra commits and a huge diff included. Please clean up the branch or start a new one only with the net new changes. |
Contributor
|
Caution Review failedFailed to post review comments. WalkthroughThis update introduces major enhancements and restructuring to documentation across the project, especially for backend integrations (vLLM, SGLang, TensorRT-LLM) and their deployment guides. It adds detailed feature support matrices, clarifies installation steps (notably for SGLang), consolidates and corrects documentation links, and provides new or updated guides for Kubernetes, SLURM, and multi-node deployments. Minor code changes propagate model-awareness in component and metrics handling. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Docs
participant Backend (vLLM/SGLang/TRTLLM)
participant Metrics
participant DeployTool (K8s/SLURM/Helm)
User->>Docs: Reads feature matrix, install, and deployment guides
User->>DeployTool: Follows deployment instructions (K8s/SLURM/Helm)
DeployTool->>Backend: Launches backend with specified model/config
Backend->>Metrics: Reports metrics with model-aware labels
User->>Backend: Sends inference requests
Backend->>User: Returns results
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
…rvice_name has been removed in PR#2349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Add a "model" label to Component metrics.
Details:
This pull request introduces model-specific metrics by adding a model field to the Component struct and updating the metrics labeling logic.
Changes
Where should the reviewer start?
lib/runtime/src/component.rs:
modelis added to Component/Endpoint.lib/runtime/src/metrics.rs: how model label is added to the metrics.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
DIS-360 Add a "model" label to Component metrics
Summary by CodeRabbit