Skip to content

Conversation

@athreesh
Copy link
Contributor

@athreesh athreesh commented Aug 5, 2025

Cherry-picks the following docs commits from anish-index-rst into release/0.4.0:

  • 7c22186 fix trt-llm readme per ryan's feedback on attention dp
  • bf635e9 adding in docs reference for metrics
  • 86abbdb fix all readmes + added in quickstart commands
  • c7acb6d update --use-kv-events to --kv-events flag
  • 77058d8 updating planner doc
  • 66f63dd fixes
  • 755a6d7 fixing broken links

Resolved merge conflicts in:

  • components/backends/sglang/README.md
  • docs/examples/README.md

Tested by verifying all files build cleanly and doc content renders.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 5, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@athreesh athreesh requested review from atchernych and kmkelle-nv and removed request for kmkelle-nv August 5, 2025 20:25
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

📚 Documentation Preview

📖 View Latest Documentation: https://crispy-winner-3jnj38w.pages.github.io/release/0.4.0/pr-2319/

Latest Deployment:

  • Commit: d49073ae (latest push)
  • Target: release/0.4.0
  • Updated: 8/6/25, 4:28 AM UTC

Note: This link always shows the documentation for the latest commit. It may take a few minutes for GitHub Pages to update after each push.


Auto-updated by the documentation deployment workflow

Copy link
Contributor

@atchernych atchernych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming docs/components/backends/sglang/README.md is a symlink

@dmitry-tokarev-nv dmitry-tokarev-nv changed the title Backport/anish index rst into 0.4.0 fix: Backport/anish index rst into 0.4.0 - fix links in docs and more Aug 5, 2025
@github-actions github-actions bot added the fix label Aug 5, 2025
@athreesh athreesh requested review from a team, ishandhanani, nealvaidya and whoisj as code owners August 6, 2025 00:29
Copy link
Contributor

@biswapanda biswapanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
verified that

  • doc builds without errors
  • built doc looks fine

@dmitry-tokarev-nv dmitry-tokarev-nv merged commit 167c793 into release/0.4.0 Aug 6, 2025
12 checks passed
@dmitry-tokarev-nv dmitry-tokarev-nv deleted the backport/anish-index-rst-into-0.4.0 branch August 6, 2025 11:07
tzulingk pushed a commit that referenced this pull request Aug 8, 2025
…#2319)

Signed-off-by: Anish <[email protected]>
Co-authored-by: Kristen Kelleher <[email protected]>
Co-authored-by: Biswa Panda <[email protected]>
Co-authored-by: Neal Vaidya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants