Repository navigation
chore(codeowners): add global router team as co-owner of workspace Cargo.toml and Cargo.lock - #17522
sachalmalick wants to merge 1 commit into
Conversation
…rgo files Global Router crate and dependency changes touch the workspace Cargo.toml and Cargo.lock, which are owned by ops alone. Add global-router as a co-owner (ops kept), mirroring how sidecar was added as a co-owner of its shared paths, so the global router team can approve those changes without waiting on ops. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016XAk4nodBkjw1fYrFr9b3x Signed-off-by: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Shared Cargo ownership rules .github/codeowners/areas.yaml, CODEOWNERS |
Both ownership configuration files assign the Cargo manifest and lockfile to ops and global-router. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Merge Risk: 
87b3f
-
No actionable merge-blocking risk is evident in this ownership-only change.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly states the main change: adding the Global Router team as a co-owner of the workspace Cargo.toml and Cargo.lock files. Description check The description includes all required sections and explains the ownership change, generated-file update, validation steps, and outstanding issue-link status. The checklist remains unchecked and no tra… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description includes all required sections and explains the ownership change, generated-file update, validation steps, and outstanding issue-link status. The checklist remains unchecked and no tracking issue is linked, but these omissions do not make the description incomplete.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![dynamo-review-agent[bot]](https://avatars.githubusercontent.com/u/201626793?s=60&v=4){kind=small}
Overview
Global Router work (e.g. #17355, #17208) keeps touching the workspace
Cargo.tomlandCargo.lockto add crates and dependencies. Today those two files are owned by@ai-dynamo/dynamo-ops-codeownersalone, so every such change waits on ops. This PR adds@ai-dynamo/dynamo-global-router-codeownersas a co-owner of both, following the sameshared:co-ownership approach used to add the sidecar team (#16826).Key Changes
.github/codeowners/areas.yaml: newsharedentries forCargo.lockandCargo.tomlwith ownersops+global-router(ops kept).CODEOWNERS: regenerated withemit_codeowners.py, not hand-edited.Under the "any one approves" rule, either team can now approve changes to these files.
Validation
build_codeowners.py --strictpasses.emit_codeowners.pyoutput is committed.who_owns.py Cargo.toml Cargo.lockshows@ai-dynamo/dynamo-ops-codeowners @ai-dynamo/dynamo-global-router-codeowners.Issues and Ongoing Work
PR Issue Linkcheck.Pull Request Checklist
/pr-checklistskill.Generated by Claude Code
Summary by CodeRabbit