Repository navigation
chore(global-router): add the Global Router crates and route lib/global-* to the global router team - #17355
Conversation
Signed-off-by: Sachal Malick <s@chal.ai>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Register and describe Global Router crates Cargo.toml, lib/global-*/Cargo.toml, lib/global-*/src/lib.rs |
The workspace now includes seven Global Router packages. Each package has workspace-inherited metadata and a module-level description. |
Route crate paths to code owners .github/codeowners/areas.yaml, CODEOWNERS |
Both ownership configurations now include matching lib/global-*/** paths for the Global Router code owners. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Merge Risk: 
Minimal · up to a10d8
-
The scaffolding matches the stated setup objective, with no merge-blocking risk identified.
Pre-merge checks: 
5
-
Full details: Description check
-
Explanation
The description explains the scope, lists all seven crates, documents workspace and code ownership changes, includes validation results, and references issue
#17354. It uses Summary and Validation headings instead of every template heading, but it provides the required information.
Full details: Linked Issues check
-
Explanation
Issue
#17354requires seven empty library crates, workspace membership, and ownership forlib/global-*/**. The reviewed changes add all sevendynamo-global-*manifests and library files, add the seven workspace members, and add the requested ownership mapping. The reported formatting and clippy checks cover the new crates. No additional coding requirement is stated.
Full details: Out of Scope Changes check
-
Explanation
The changes stay within issue
#17354. The crate manifests, module documentation, license headers, workspace update, and generated CODEOWNERS update support the requested crate setup and ownership routing. No unrelated implementation or unrelated product behavior is shown.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 7 files. (10 skipped: 10 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
/ok to test a10d8b9 |
Main now has #17355, which adds empty lib/global-* crates, lib/global-common among them, and routes lib/global-*/** to the Global Router team. Where both sides changed the same lines, main's version is kept: the workspace members, the CODEOWNERS glob, and the crate's package metadata and summary line. This branch keeps its modules, dependencies, workspace dependency entry and Cargo.lock entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
…very-register-router The base now has main, with #17355's Global Router crates. No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
…very-pool-registrations The base now has main, with #17355's Global Router crates. No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
Summary
Adds empty crates for the Global Router components and routes them to the global router team. Code for each component can then land later without touching the workspace or code ownership. Each crate is a library containing only a manifest and a one-line doc comment.
lib/global-commondynamo-global-commonlib/global-discovery-clientdynamo-global-discovery-clientlib/global-discovery-servicedynamo-global-discovery-servicelib/global-frontenddynamo-global-frontendlib/global-routerdynamo-global-routerlib/global-view-broadcasterdynamo-global-view-broadcasterlib/global-view-receiverdynamo-global-view-receiverCargo.tomllists the seven crates as members.Cargo.lockadds only these seven packages. CI filters already coverlib/**, and the release scripts find crates from the workspace members, so nothing else needs to change..github/codeowners/areas.yamladdslib/global-*/**to theglobal-routerarea (@ai-dynamo/dynamo-global-router-codeowners), andCODEOWNERSis regenerated. Because it's a glob, a laterlib/global-*crate needs no code-ownership change. The pattern ends in/**rather than/becausecodeowners_match.pytreats a pattern ending in/as a literal prefix and does not expand*in it. That would leave the glob matching nothing.Validation
cargo clippy -p dynamo-global-{common,discovery-client,discovery-service,frontend,router,view-broadcaster,view-receiver} --all-targets -- -D warningspasses.cargo fmt --checkon the same crates passes.build_codeowners.py --strict: 7101/7101 tracked files are explicitly owned, with no stale globs.CODEOWNERSwithemit_codeowners.pyproduces no drift.who_owns.pyroutes every new file to@ai-dynamo/dynamo-global-router-codeowners. The PR also requests the ops and process teams because it touchesareas.yaml,CODEOWNERSand the root Cargo files.Related Issues
🤖 Generated with Claude Code
Summary by CodeRabbit