Skip to content

chore(codeowners): share workspace Cargo ownership with Runtime - #17582

Draft
sttts wants to merge 2 commits into
mainfrom
sttts-ops-codeowners-scope
Draft

sttts wants to merge 2 commits into
mainfrom
sttts-ops-codeowners-scope

Conversation

@sttts

@sttts sttts commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Overview / Summary

Root Cargo.toml and Cargo.lock currently require an Ops codeowner approval even when a Runtime reviewer has already approved the PR. Add Runtime as an alternative codeowner while retaining Ops ownership. This broadens who may satisfy the codeowner requirement; it does not remove Ops from review requests or require an approval from both teams.

Key Changes

Core logic: 0 lines; two shared ownership declarations and regenerated CODEOWNERS.

  1. Keep the existing Ops area claims for both root Cargo files.
  2. Add shared [ops, runtime] owner sets for those exact files.
  3. Preserve all other ownership, including GitHub CI, Dockerfiles, Docs, component dependencies, and deployment tests. Existing policy validation and required-owner contracts are unchanged.

Complete file-by-file ownership changes

These are the only two tracked files whose ownership changes, compared with base 8817a97394. The PR edits .github/codeowners/areas.yaml and its generated root CODEOWNERS; it does not edit the Cargo files themselves.

File Owners before Owners after
Cargo.lock @ai-dynamo/dynamo-ops-codeowners @ai-dynamo/dynamo-ops-codeowners, @ai-dynamo/dynamo-runtime-codeowners
Cargo.toml @ai-dynamo/dynamo-ops-codeowners @ai-dynamo/dynamo-ops-codeowners, @ai-dynamo/dynamo-runtime-codeowners

GitHub combines owners on a row with OR: either team can satisfy ownership for that file. Other changed files in the same PR may still require different owners, including Ops.

Validation

  • All 158 existing CODEOWNERS tests pass. Temporary Git fixtures use hooks.allowDirectMain=true only in the test-process environment; the tests and signing checks are unchanged.
  • Strict policy validation covers all 7,261 tracked files (100%), including stale-policy, shared-additivity, file-type and required-owner contracts. Generator output is reproducible.
  • Comparing every tracked path with the base finds exactly the two ownership changes listed above. Every existing owner is retained; all other owner sets are identical.

Approval-eligibility replay, not review-request reduction: the local dataset contains 2,161 PRs merged during the 90 days ending October 28, 2026. Only the 1,731 PRs targeting main are considered. Applying the baseline policy and the October 28 team-membership snapshot identifies 97 modeled cases where all uncovered file ownership was exclusively Ops, with Ops supplying the final approval.

With the recorded approvals held fixed, adding Runtime to the two Cargo files would cover all files already at the penultimate approval in 34 of those 97 cases (35.1%). Their last-to-penultimate approval gaps total 798.9 hours (29.1% of the modeled baseline cohort's 2,746.3 hours). Both reviews referenced the same commit in 24 of those cases, totaling 328.2 gap hours.

These are modeled approval-eligibility gaps, not verified saved merge time or reviewer work. Approval state is reconstructed independently at each checkpoint so a later re-approval does not erase an earlier valid approval by the same reviewer. Cases with dismissed-review history or incomplete final baseline coverage are excluded. Historical policy/membership changes, CI, intervening pushes, unresolved discussions, bypasses, and extra approvals for unattributed changes are not reconstructed; matching review commits do not prove uninterrupted merge readiness. The model requires every changed file to be covered, not merely a Runtime approval somewhere on the PR.

Issues and Ongoing Work

Pull Request Checklist
  • I used Dynamo's /pr-checklist skill.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@devin-ai-integration

devin-ai-integration Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

✅ Dynamo PR CI passed — run 40853897805 (attempt 1) on b0d0b23401

Gate checks: ✅ backend-status-check · ✅ deploy-status-check · ✅ dynamo-status-check

Posted automatically by Devin for run 40853897805. Updated on every full-CI run of this PR.

Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
@pull-request-size pull-request-size Bot added size/S and removed size/M labels Oct 29, 2026
@sttts sttts changed the title chore(codeowners): route scoped dependencies and Rust metadata to functional owners chore(codeowners): share workspace Cargo ownership with Runtime Oct 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant