Repository navigation
Conversation
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
Contributor
✅ Dynamo PR CI passed — run 40853897805 (attempt 1) on
|
Signed-off-by: Dr. Stefan Schimanski <sschimanski@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview / Summary
Root
Cargo.tomlandCargo.lockcurrently require an Ops codeowner approval even when a Runtime reviewer has already approved the PR. Add Runtime as an alternative codeowner while retaining Ops ownership. This broadens who may satisfy the codeowner requirement; it does not remove Ops from review requests or require an approval from both teams.Key Changes
Core logic: 0 lines; two shared ownership declarations and regenerated
CODEOWNERS.[ops, runtime]owner sets for those exact files.Complete file-by-file ownership changes
These are the only two tracked files whose ownership changes, compared with base
8817a97394. The PR edits.github/codeowners/areas.yamland its generated rootCODEOWNERS; it does not edit the Cargo files themselves.@ai-dynamo/dynamo-ops-codeowners@ai-dynamo/dynamo-ops-codeowners,@ai-dynamo/dynamo-runtime-codeowners@ai-dynamo/dynamo-ops-codeowners@ai-dynamo/dynamo-ops-codeowners,@ai-dynamo/dynamo-runtime-codeownersGitHub combines owners on a row with OR: either team can satisfy ownership for that file. Other changed files in the same PR may still require different owners, including Ops.
Validation
hooks.allowDirectMain=trueonly in the test-process environment; the tests and signing checks are unchanged.Approval-eligibility replay, not review-request reduction: the local dataset contains 2,161 PRs merged during the 90 days ending October 28, 2026. Only the 1,731 PRs targeting
mainare considered. Applying the baseline policy and the October 28 team-membership snapshot identifies 97 modeled cases where all uncovered file ownership was exclusively Ops, with Ops supplying the final approval.With the recorded approvals held fixed, adding Runtime to the two Cargo files would cover all files already at the penultimate approval in 34 of those 97 cases (35.1%). Their last-to-penultimate approval gaps total 798.9 hours (29.1% of the modeled baseline cohort's 2,746.3 hours). Both reviews referenced the same commit in 24 of those cases, totaling 328.2 gap hours.
These are modeled approval-eligibility gaps, not verified saved merge time or reviewer work. Approval state is reconstructed independently at each checkpoint so a later re-approval does not erase an earlier valid approval by the same reviewer. Cases with dismissed-review history or incomplete final baseline coverage are excluded. Historical policy/membership changes, CI, intervening pushes, unresolved discussions, bypasses, and extra approvals for unattributed changes are not reconstructed; matching review commits do not prove uninterrupted merge readiness. The model requires every changed file to be covered, not merely a Runtime approval somewhere on the PR.
Issues and Ongoing Work
lib/bindings/kvbm/Cargo.lock. That different path and the exemption mechanism are untouched here.Pull Request Checklist
/pr-checklistskill.