Repository navigation
ci(test): keep known kr8s Kubernetes 1.36 warnings nonfatal - #17285
Conversation
Signed-off-by: xianlubird <xianlubird@gmail.com>
|
/ok to test 1a3c750 |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Configure the warning filter pyproject.toml |
Pytest displays matching UserWarnings from kr8s._api by default instead of treating them as errors. Other warnings are unaffected by this filter. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Severity of issue fixed: Medium
Merge Risk: 
Minimal · up to 1a3c7
-
No actionable merge-blocking risk remains in this focused configuration change.
Pre-merge checks: 
5
-
Full details: Description check
-
Explanation
The description explains the failure, the scoped fix, temporary intent, validation, limitations, and linked issue. It does not use the template headings for Overview, Details, or reviewer starting point, but it provides the required information in equivalent sections.
Full details: Linked Issues check
-
Explanation
Issue
#17284requires a nonfatal but visible filter for the kr8s 0.20.13 Kubernetes 1.36 warning.pyproject.tomladds adefaultfilter that matches the exact warning text,UserWarning, andkr8s._api. The expression limits the match to Kubernetes 1.36 patch releases and kr8s 0.20.13. The existingerrorrule remains in place, so unrelated warnings and Kubernetes API errors retain their existing behavior. The reported validation covers supported and unsupported version boundaries, unrelated warnings, another warning origin, and HTTP 403 propagation.
Full details: Out of Scope Changes check
-
Explanation
The whole-PR change adds only the pytest warning rule and its explanatory comments in
pyproject.toml. The change directly supports issue#17284and does not include unrelated implementation or configuration changes.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
✅ Dynamo PR CI passed — run 40261697628 (attempt 1) on
|
Summary
Deploy and checkpoint tests on Kubernetes 1.36.4 abort during kr8s client initialization because pytest turns its supported-version warning into an exception. Keep that warning visible with
default, scoped to Kubernetes 1.36.x, the pinned kr8s 0.20.13 warning text, andkr8s._api. Other warnings and Kubernetes API errors keep their existing behavior.The latest published kr8s release, 0.20.15, still only declares support through Kubernetes 1.35. Upstream has added 1.36 to its test matrix in kr8s-org/kr8s#744. Remove this temporary filter when the pinned release supports 1.36.
Closes #17284.
Validation
/versionresponse and pytest's warnings-as-errors policy.pyproject.tomlthrough pytest's configuration filter path: 8 checks passed, with the Kubernetes 1.36.4 warning still displayed. Covered a supported cluster, future/older unsupported and unparseable versions, unrelated warnings, the same message from another module, and propagation of an HTTP 403 error.git diff --checkpassed.Summary by CodeRabbit