Skip to content

ci(test): keep known kr8s Kubernetes 1.36 warnings nonfatal - #17285

Merged
nv-anants merged 1 commit into
ai-dynamo:mainfrom
xianlubird:bug/kr8s-kubernetes-136-warning
Oct 26, 2026
Merged

nv-anants merged 1 commit into
ai-dynamo:mainfrom
xianlubird:bug/kr8s-kubernetes-136-warning

Conversation

@xianlubird

@xianlubird xianlubird commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Deploy and checkpoint tests on Kubernetes 1.36.4 abort during kr8s client initialization because pytest turns its supported-version warning into an exception. Keep that warning visible with default, scoped to Kubernetes 1.36.x, the pinned kr8s 0.20.13 warning text, and kr8s._api. Other warnings and Kubernetes API errors keep their existing behavior.

The latest published kr8s release, 0.20.15, still only declares support through Kubernetes 1.35. Upstream has added 1.36 to its test matrix in kr8s-org/kr8s#744. Remove this temporary filter when the pinned release supports 1.36.

Closes #17284.

Validation

  • Reproduced the original failure using installed kr8s 0.20.13 with a mocked /version response and pytest's warnings-as-errors policy.
  • Loaded the new rule from pyproject.toml through pytest's configuration filter path: 8 checks passed, with the Kubernetes 1.36.4 warning still displayed. Covered a supported cluster, future/older unsupported and unparseable versions, unrelated warnings, the same message from another module, and propagation of an HTTP 403 error.
  • git diff --check passed.
  • Live Kubernetes/GPU deployment and checkpoint behavior remains to be validated by CI; the local checks do not establish runtime compatibility with Kubernetes 1.36.

Summary by CodeRabbit

  • Tests
    • The test configuration now uses default handling for a specific Kubernetes compatibility warning from kr8s. Other warnings retain their existing behavior.

Signed-off-by: xianlubird <xianlubird@gmail.com>
@xianlubird
xianlubird requested a review from a team as a code owner October 26, 2026 02:57
@copy-pr-bot

copy-pr-bot Bot commented Oct 26, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@xianlubird
xianlubird temporarily deployed to external_collaborator October 26, 2026 02:57 — with GitHub Actions Inactive
@xianlubird
xianlubird temporarily deployed to external_collaborator October 26, 2026 02:57 — with GitHub Actions Inactive
@github-actions github-actions Bot added ci Issues/PRs that reference CI build/test external-contribution Pull request is from an external contributor trusted-contributor Org-External user who is trusted to run CI without Org-member approval labels Oct 26, 2026
@dynamo-ops

Copy link
Copy Markdown
Contributor

/ok to test 1a3c750

@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between ee01209 and 1a3c750.

Files selected for processing: 1
  • pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

Pytest configuration adds a warning filter for the Kubernetes 1.36 compatibility warning emitted by kr8s 0.20.13. The filter applies to matching warnings from kr8s._api.

Changes

Pytest warning handling

Layer / File(s) Summary
Configure the warning filter
pyproject.toml
Pytest displays matching UserWarnings from kr8s._api by default instead of treating them as errors. Other warnings are unaffected by this filter.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Severity of issue fixed: Medium

Merge Risk: Minimal · up to 1a3c7

No actionable merge-blocking risk remains in this focused configuration change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the main change: preventing known kr8s Kubernetes 1.36 warnings from failing tests.
Description check Passed The description explains the failure, the scoped fix, temporary intent, validation, limitations, and linked issue. It does not use the template headings for Overview, Details, or reviewer starting poi…
Linked Issues check Passed Issue #17284 requires a nonfatal but visible filter for the kr8s 0.20.13 Kubernetes 1.36 warning. pyproject.toml adds a default filter that matches the exact warning text, UserWarning, and `kr8s…
Out of Scope Changes check Passed The whole-PR change adds only the pytest warning rule and its explanatory comments in pyproject.toml. The change directly supports issue #17284 and does not include unrelated implementation or confi…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Description check

Explanation

The description explains the failure, the scoped fix, temporary intent, validation, limitations, and linked issue. It does not use the template headings for Overview, Details, or reviewer starting point, but it provides the required information in equivalent sections.

Full details: Linked Issues check

Explanation

Issue #17284 requires a nonfatal but visible filter for the kr8s 0.20.13 Kubernetes 1.36 warning. pyproject.toml adds a default filter that matches the exact warning text, UserWarning, and kr8s._api. The expression limits the match to Kubernetes 1.36 patch releases and kr8s 0.20.13. The existing error rule remains in place, so unrelated warnings and Kubernetes API errors retain their existing behavior. The reported validation covers supported and unsupported version boundaries, unrelated warnings, another warning origin, and HTTP 403 propagation.

Full details: Out of Scope Changes check

Explanation

The whole-PR change adds only the pytest warning rule and its explanatory comments in pyproject.toml. The change directly supports issue #17284 and does not include unrelated implementation or configuration changes.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration

Copy link
Copy Markdown
Contributor

✅ Dynamo PR CI passed — run 40261697628 (attempt 1) on 1a3c7507e7

Gate checks: ✅ backend-status-check · ✅ deploy-status-check · ✅ dynamo-status-check

Posted automatically by Devin for run 40261697628. Updated on every full-CI run of this PR.

@nv-anants
nv-anants merged commit 2b16a69 into ai-dynamo:main Oct 26, 2026
121 checks passed
@xianlubird
xianlubird deleted the bug/kr8s-kubernetes-136-warning branch October 27, 2026 00:52
sungsooha pushed a commit to sungsooha/dynamo that referenced this pull request Nov 4, 2026
…o#17285)

Signed-off-by: xianlubird <xianlubird@gmail.com>
(cherry picked from commit 2b16a69)
Signed-off-by: Sungsoo Ha <sungsooh@nvidia.com>
dagil-nvidia pushed a commit that referenced this pull request Nov 4, 2026
…s nonfatal (#17285) (#18088)

Signed-off-by: xianlubird <xianlubird@gmail.com>
Signed-off-by: Dmitry Tokarev <dtokarev@nvidia.com>
Co-authored-by: Xianlu Bird <xianlubird@gmail.com>

This branch was previously deployed

1 inactive deployment
external_collaborator — 1a3c7507 Deployed Oct 26, 2026 by xianlubird via ok-to-test #38608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Issues/PRs that reference CI build/test external-contribution Pull request is from an external contributor size/XS trusted-contributor Org-External user who is trusted to run CI without Org-member approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy CI fails on Kubernetes 1.36 because kr8s version warnings become errors

4 participants