Repository navigation
Conversation
…kflow) shared-test.yml requires the `framework` input, but the triton-test job added in #13774 omits it. Because a reusable-workflow call missing a required input fails workflow *startup* validation, this breaks the entire `PR` workflow at startup for every PR based on main — repo-wide, not triton-specific. Root cause is a merge skew: #14688 made `framework` required in shared-test.yml and #13774 added triton-test in parallel without it; neither PR re-ran against the other (triton jobs are path-filtered to "skipped" on unrelated diffs), so the break only appeared once both were on main. Every other shared-test caller (vllm/sglang/trtllm/planner) already passes `framework`; this adds the missing `framework: triton` to match. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: nnshah1 <neelays@nvidia.com>
|
/ok to test 4533984 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe Triton test job now passes ChangesTriton test workflow
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to The workflow startup failure is addressed, with no remaining merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the root cause, impact, change, and validation. However, it does not follow the required template headings and omits the required Related Issues section, including confirmation that no related issue exists or a valid issue reference.
Comment |
| uses: $/.github/workflows/shared-test.yml | ||
| with: | ||
| test_suite_name: triton | ||
| framework: triton # matches the framework passed to triton-build |
There was a problem hiding this comment.
The inline comment only restates the matching framework value and nearby build-job relationship; it does not record a lasting constraint beyond the configuration itself.
🤖 AI Fix
Remove the inline comment.
Summary
Fixes a repo-wide
PR-workflowstartup_failurethat has blocked heavy CI on every PR based on main since ~2026-09-11 23:00 UTC.shared-test.ymldeclaresframeworkas a required input, but thetriton-testjob (added in #13774) does not pass it. A reusable-workflow call missing a required input fails workflow startup validation, which aborts the entirePRworkflow before any job runs — so this is not triton-specific, it breaks CI for all PRs.Root cause — merge skew: #14688 made
frameworkrequired inshared-test.yml; #13774 addedtriton-testin parallel without it. Neither PR re-ran against the other (triton jobs are path-filtered toskippedon unrelated diffs), so the break only surfaced once both landed on main.Every other
shared-testcaller (vllm / sglang / trtllm / planner) already passesframework. This adds the missingframework: tritonto match — a one-line change.Validation
pr.yamlparses as valid YAML.shared-test.ymlcallers now pass the requiredframeworkinput (verified per-job;triton-testwas the only one missing it).Regression from #13774 (× #14688).
Summary by CodeRabbit