Skip to content

fix(ci): pass framework to Triton test workflows - #14760

Merged
nv-ashwinkumarr merged 1 commit into
ai-dynamo:mainfrom
bzsuni:fix/triton-ci-framework-input
Sep 14, 2026
Merged

nv-ashwinkumarr merged 1 commit into
ai-dynamo:mainfrom
bzsuni:fix/triton-ci-framework-input

Conversation

@bzsuni

@bzsuni bzsuni commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Overview

The Triton test jobs added in #13774 call shared-test.yml without its required framework input.

Because framework is a required workflow_call input, the affected workflows fail during workflow validation before any jobs are created.

This affects both full PR CI and post-merge CI.

Details

Pass framework: triton to the Triton test jobs in:

  • .github/workflows/pr.yaml
  • .github/workflows/post-merge-ci.yml

The existing vLLM, SGLang, TRT-LLM, and Dynamo callers already pass the corresponding framework value.

After #13774 merged, its post-merge workflow ended immediately with startup_failure and created no jobs. PR branches using the updated workflow have also failed to start the full PR workflow or reported startup_failure.

This change only supplies the missing required input and does not change Triton test selection or execution behavior.

Where should the reviewer start?

  • .github/workflows/pr.yaml: triton-test
  • .github/workflows/post-merge-ci.yml: triton-test

Related Issues

🚫 This PR is NOT linked to an issue:

  • Confirmed — no related issue

Summary by CodeRabbit

  • Chores
    • Updated automated testing workflows to explicitly identify Triton tests.

Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@bzsuni
bzsuni requested a review from a team as a code owner September 12, 2026 01:05
@copy-pr-bot

copy-pr-bot Bot commented Sep 12, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bzsuni
bzsuni deployed to external_collaborator September 12, 2026 01:05 — with GitHub Actions Active
@bzsuni
bzsuni deployed to external_collaborator September 12, 2026 01:05 — with GitHub Actions Active
@github-actions github-actions Bot added the fix label Sep 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi bzsuni! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions Bot added external-contribution Pull request is from an external contributor actions labels Sep 12, 2026
@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6114b219-bebf-4fe1-817e-2d9a3bdfb038

📥 Commits

Reviewing files that changed from the base of the PR and between 0027a8e and 05f0451.

📒 Files selected for processing (2)
  • .github/workflows/post-merge-ci.yml
  • .github/workflows/pr.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The pull request passes framework: triton to the Triton test reusable workflow in both pull request and post-merge CI workflows.

Changes

Triton workflow wiring

Layer / File(s) Summary
Pass Triton framework to test workflows
.github/workflows/post-merge-ci.yml, .github/workflows/pr.yaml
Both Triton test workflow invocations now pass framework: triton.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 05f04

The CI workflow validation issue is addressed without changing Triton test behavior.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description includes the required Overview, Details, reviewer guidance, and Related Issues sections. It explains the cause, affected workflows, exact files, and scope of the fix. It also confirms …
Title check ✅ Passed The title clearly and concisely describes the main change: passing the required framework input to Triton test workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@rmccorm4

Copy link
Copy Markdown
Contributor

/ok to test 05f0451

@rmccorm4

rmccorm4 commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

CC @nv-anants @nv-rinig for Monday

@nnshah1

nnshah1 commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Thanks for this @bzsuni — confirmed it fixes the repo-wide startup_failure (the PR workflow now starts).

The remaining red on this PR is a separate, pre-existing gap the fix just uncovered — these CPU test jobs never actually ran while startup was broken, so this is newly surfaced, not caused by your change:

triton-runtime and planner CPU tests both fail with a single collection error, 0 actual test failures:

ERROR benchmarks/router/tests/test_common.py - ModuleNotFoundError: No module named 'networkx'

benchmarks.router.common imports networkx (declared in benchmarks/pyproject.toml, but not installed in the CPU test image). pytest collects the whole tree before marker filtering, so that one benchmarks module fails collection for every CPU test job.

It's independent of your one-line fix, so no obligation to take it on here — but since it blocks this PR and every PR will hit it once startup is fixed, it may be worth folding in. Minimal unblock is to guard the optional import at the top of benchmarks/router/tests/test_common.py:

import pytest

pytest.importorskip("networkx")

(Proper alternative, if these tests should always run: install the benchmarks deps / networkx in the CPU test image.) Either way — thanks for unblocking the startup issue.

— Neelay + 🤖

@bzsuni

bzsuni commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

@nv-rinig @nnshah1 The networkx collection issue is already addressed in #14671.

Since this PR fixes the repo-wide PR workflow startup failure that is currently blocking CI for other PRs as well, would it make sense to merge this PR first and let #14671 handle the separate networkx issue afterward?

@bzsuni bzsuni mentioned this pull request Sep 13, 2026
1 task done
@bzsuni

bzsuni commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

@nnshah1 @nv-rinig Since #14671 is a larger change, I opened #14771 to add networkx to the test images so the CI fix can move independently.

Would you prefer to keep #14760 and #14771 separate, or combine them into this PR? Either works for me. Thanks!

@nv-ashwinkumarr
nv-ashwinkumarr merged commit f2becb5 into ai-dynamo:main Sep 14, 2026
198 of 208 checks passed
@nv-rinig

Copy link
Copy Markdown
Contributor

Hi @bzsuni I think we should keep #14771 separate since it addresses a different issue. In the meantime, to unblock the rest of the PR CI, we have force-merged this PR - thank you for fixing it so quickly!

nv-nmailhot pushed a commit that referenced this pull request Sep 15, 2026
…13774) (#14760) (#14827)

Signed-off-by: Dan Gil <dagil@nvidia.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
MatejKosec pushed a commit to glamr-agent/dynamo that referenced this pull request Sep 16, 2026
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
(cherry picked from commit f2becb5)
Signed-off-by: Matej Kosec <mkosec@nvidia.com>

This branch was successfully deployed

1 active deployment
external_collaborator — 05f04513 Deployed Sep 12, 2026 by bzsuni via ok-to-test #17695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions external-contribution Pull request is from an external contributor fix size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants