Repository navigation
fix(ci): pass framework to Triton test workflows - #14760
Conversation
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
|
👋 Hi bzsuni! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe pull request passes ChangesTriton workflow wiring
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The CI workflow validation issue is addressed without changing Triton test behavior. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
|
/ok to test 05f0451 |
|
CC @nv-anants @nv-rinig for Monday |
|
Thanks for this @bzsuni — confirmed it fixes the repo-wide The remaining red on this PR is a separate, pre-existing gap the fix just uncovered — these CPU test jobs never actually ran while startup was broken, so this is newly surfaced, not caused by your change:
It's independent of your one-line fix, so no obligation to take it on here — but since it blocks this PR and every PR will hit it once startup is fixed, it may be worth folding in. Minimal unblock is to guard the optional import at the top of import pytest
pytest.importorskip("networkx")(Proper alternative, if these tests should always run: install the — Neelay + 🤖 |
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io> (cherry picked from commit f2becb5) Signed-off-by: Matej Kosec <mkosec@nvidia.com>
Overview
The Triton test jobs added in #13774 call
shared-test.ymlwithout its requiredframeworkinput.Because
frameworkis a requiredworkflow_callinput, the affected workflows fail during workflow validation before any jobs are created.This affects both full PR CI and post-merge CI.
Details
Pass
framework: tritonto the Triton test jobs in:.github/workflows/pr.yaml.github/workflows/post-merge-ci.ymlThe existing vLLM, SGLang, TRT-LLM, and Dynamo callers already pass the corresponding
frameworkvalue.After #13774 merged, its post-merge workflow ended immediately with
startup_failureand created no jobs. PR branches using the updated workflow have also failed to start the fullPRworkflow or reportedstartup_failure.This change only supplies the missing required input and does not change Triton test selection or execution behavior.
Where should the reviewer start?
.github/workflows/pr.yaml:triton-test.github/workflows/post-merge-ci.yml:triton-testRelated Issues
🚫 This PR is NOT linked to an issue:
Summary by CodeRabbit