feat(pystr): Pass command line arguments #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamking
requested review from
GuanLuo,
biswapanda,
paulhendricks,
rmccorm4,
ryanolson and
tmonty12
as code owners
rmccorm4
reviewed
Mar 12, 2025
Test Results88 tests 88 ✅ 51s ⏱️ Results for commit f5b07faa. |
Command line arguments are passed to the python engine like this:
```
dynamo-run out=pystr:my_python_engine.py -- -n 42 --custom-arg Orange --yes
```
The python engine has two options for receiving those command line arguments (both of which are optional).
In both cases the argument list will include some standard ones as well as anything after the `--`.
This input:
```
dynamo-run out=pystr:my_engine.py /opt/models/Llama-3.2-3B-Instruct/ --model-name llama_3.2 --tensor-parallel-size 4 -- -n 1
```
1. In `sys.argv`:
```
async def generate(request):
.. as before ..
if __name__ == "__main__":
print(f"MAIN: {sys.argv}")
```
Produces this output:
```
MAIN: ['my_engine.py', '--model-path', '/opt/models/Llama-3.2-3B-Instruct/', '--model-name', 'llama3.2', '--http-port', '8080', '--tensor-parallel-size', '4', '--base-gpu-id', '0', '--num-nodes', '1', '--node-rank', '0', '-n', '1']
```
This form allows quick iteration on the engine setup.
2. In an `initialize` function:
```
async def generate(request):
.. as before ..
def initialize(args: list[str]) -> None:
print(f"initialize: {args}")
```
Produces this output:
```
initialize: ['--model-path', '/opt/models/Llama-3.2-3B-Instruct/', '--model-name', 'llama3.2', '--http-port', '8080', '--tensor-parallel-size', '4', '--base-gpu-id', '0', '--num-nodes', '1', '--node-rank', '0', '-n', '1']
```
Note how in both cases the `-n` `1` is included.
Flags `--leader-addr` and `--model-config` will also be added if provided to `dynamo-run`.
Less is more.
kylehh
pushed a commit
to kylehh/dynamo
that referenced
this pull request
Apr 11, 2025
Signed-off-by: Ryan Olson <[email protected]> Co-authored-by: Ryan McCormick <[email protected]> Co-authored-by: Neelay Shah <[email protected]>
kylehh
pushed a commit
to kylehh/dynamo
that referenced
this pull request
Apr 11, 2025
Command line arguments are passed to the python engine like this:
```
dynamo-run out=pystr:my_python_engine.py -- -n 42 --custom-arg Orange --yes
```
The python engine receives the arguments in `sys.argv`. The argument list will include some standard ones as well as anything after the `--`.
This input:
```
dynamo-run out=pystr:my_engine.py /opt/models/Llama-3.2-3B-Instruct/ --model-name llama_3.2 --tensor-parallel-size 4 -- -n 1
```
is read like this:
```
async def generate(request):
.. as before ..
if __name__ == "__main__":
print(f"MAIN: {sys.argv}")
```
and produces this output:
```
MAIN: ['my_engine.py', '--model-path', '/opt/models/Llama-3.2-3B-Instruct/', '--model-name', 'llama3.2', '--http-port', '8080', '--tensor-parallel-size', '4', '--base-gpu-id', '0', '--num-nodes', '1', '--node-rank', '0', '-n', '1']
```
This allows quick iteration on the engine setup. Note how the `-n` `1` is included. Flags `--leader-addr` and `--model-config` will also be added if provided to `dynamo-run`.
This was referenced Sep 10, 2025
This was referenced Sep 17, 2025
This was referenced Sep 27, 2025
Merged
This was referenced Oct 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command line arguments are passed to the python engine like this:
The python engine receives the arguments in
sys.argv. The argument list will include some standard ones as well as anything after the--.This input:
is read like this:
and produces this output:
This allows quick iteration on the engine setup. Note how the
-n1is included. Flags--leader-addrand--model-configwill also be added if provided todynamo-run.