fix: update post-create.sh for current build system and fix unbound variables

[keivenchang]

Overview:

This PR fixes the devcontainer post-create script to work with the current build system and resolves bash strict mode errors. The script was failing due to deprecated build features and unbound variable references.

Details:

• Replace deprecated mistralrs cargo feature with current dynamo-llm/block-manager feature
• Fix unbound variable errors by using ${VARIABLE:-} parameter expansion syntax for bash strict mode compatibility
• Reorder set +x command placement for proper script flow
• Ensure devcontainer setup completes successfully without script failures

Where should the reviewer start?

Look closely at .devcontainer/post-create.sh - specifically the cargo build command change on line 66 and the unbound variable fixes throughout the script.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

/coderabbit profile chill

Summary by CodeRabbit

• New Features
  • Automatic, more robust PYTHONPATH detection and persistence in dev containers.
• Bug Fixes
  • Safer handling of unset tokens and SSH agent forwarding; reduced default debug noise.
• Chores
  • Updated build configuration for deterministic dev builds.
  • Made shell profile updates idempotent to prevent duplicate entries.

[coderabbitai]

Walkthrough

Switches the build target from mistralrs to dynamo-llm/block-manager, hardens env/token checks using parameter expansion, refines SSH agent detection, and improves PYTHONPATH derivation and persistence to .bashrc with idempotent guards. Adds quieter debug handling and safer append logic within .devcontainer/post-create.sh.

Changes

Cohort / File(s)	Summary
Build target update \.devcontainer/post-create.sh	Changes cargo build invocation to use dynamo-llm/block-manager with --locked and --profile dev.
PYTHONPATH derivation & persistence \.devcontainer/post-create.sh	Robustly derives PYTHONPATH from existing var or README.md; falls back to predefined paths; persists to ~/.bashrc only if absent; handles literal expansions of ${PYTHONPATH} and $(pwd).
Token and SSH checks hardening \.devcontainer/post-create.sh	Replaces direct var checks with parameter-expansion guards for HF_TOKEN, GITHUB_TOKEN, SSH_AUTH_SOCK; improves unset/empty handling.
Idempotent bashrc edits & quiet mode \.devcontainer/post-create.sh	Ensures sections appended once; wraps verbose blocks with debug toggles; uses set +x suppression blocks for cleaner output.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Devcontainer as Devcontainer
  participant Script as post-create.sh
  participant Cargo as cargo
  participant Shell as Bashrc (~/.bashrc)
  participant Env as Env Vars

  Devcontainer->>Script: Run post-create hook
  rect rgba(200,230,255,0.25)
    note over Script: Build step (updated target)
    Script->>Cargo: build dynamo-llm/block-manager (--locked, dev)
    Cargo-->>Script: Build result
  end

  rect rgba(220,255,220,0.25)
    note over Script: PYTHONPATH derivation
    Script->>Env: Read ${PYTHONPATH:-}
    alt PYTHONPATH preset
      Script->>Shell: Append export if not already present
    else Not set
      Script->>Script: Derive from README.md or fallback list
      Script->>Shell: Persist derived export (idempotent)
    end
  end

  rect rgba(255,245,200,0.35)
    note over Script: Credential checks (hardened)
    Script->>Env: Test ${HF_TOKEN:-}, ${GITHUB_TOKEN:-}
    Script->>Env: Test ${SSH_AUTH_SOCK:-} for agent forwarding
  end

  Script-->>Devcontainer: Completed setup (quiet when not in debug)

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibbled through the setup hay,
Swapped the build, then hopped away—
Paths now sniffed with whiskered care,
Tokens checked in cleaner air.
Bashrc burrow, neat and tight,
Agent tunnels set just right.
Thump! The dev den’s primed tonight.

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The description effectively covers the overview, details of the feature flag replacement, strict mode adjustments, and where to review the changes, but the “Related Issues” section is empty and does not include any action keywords or issue references as required by the template.	Please populate the “Related Issues” section with appropriate action keywords (e.g., “Closes #123” or “None”) to fully comply with the repository’s PR description template.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title “fix: update post-create.sh for current build system and fix unbound variables” concisely and accurately summarizes the primary updates to the devcontainer post-create script, specifically the build feature change and the bash strict mode fixes, without including extraneous details.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16409ee and 0d506c6.

📒 Files selected for processing (1)

• .devcontainer/post-create.sh (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build and Test - dynamo

🔇 Additional comments (6)

.devcontainer/post-create.sh (6)

85-86: LGTM!

The placement of { set +x; } 2>/dev/null correctly ends the debug output section after all build and install commands, ensuring proper logging while suppressing the trace output from the set command itself.

---

91-91: LGTM!

The parameter expansion ${PYTHONPATH:-} correctly prevents script failure when PYTHONPATH is unset, making it compatible with set -u strict mode.

---

125-127: LGTM!

The parameter expansion in these unset commands ensures that future shell sessions won't fail when these environment variables are not set, maintaining compatibility with bash strict mode. This correctly prevents authentication issues caused by empty token values.

---

131-131: LGTM!

The parameter expansion ${SSH_AUTH_SOCK:-} correctly prevents script failure when SSH_AUTH_SOCK is unset, ensuring compatibility with set -u strict mode.

---

1-155: Excellent bash strict mode hardening!

The changes consistently apply parameter expansion (${VAR:-}) throughout the script to prevent unbound variable errors under set -u, while maintaining the intended functionality. The script now:

• Correctly handles all potentially unset environment variables
• Maintains idempotent .bashrc modifications
• Provides comprehensive PYTHONPATH handling with fallbacks
• Updates the build system to use the current feature flag

All modifications align well with the PR objectives and follow bash best practices for strict mode compatibility.

---

66-66: dynamo-llm/block-manager feature confirmed
Verified definition in lib/llm/Cargo.toml:24 and reference in lib/bindings/python/Cargo.toml:26.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

• Public repositories are always opted into early access features.
• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}