chore: update for error messages

[nnshah1]

Overview:

Changes to make error messages for etcd connection issues more consistent (feedback from UX work)

Details:

Consistent messages with additional information

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

https://linear.app/nvidia/issue/DYN-1109/improve-error-messaging-etcd-registration-failures

Summary by CodeRabbit

• Refactor

  • Standardized and clarified error messages and logs for etcd connection, key operations, leases, and service discovery registration.
  • Added contextual error wrapping for clearer diagnostics.

• Bug Fixes

  • Cancels registration on etcd failure to prevent stale state.
  • Improves failure propagation during key creation/validation and lease refresh/expiry handling.

• Chores

  • Minor inline comment typo corrected.

[coderabbitai]

Walkthrough

Introduces internal error message constants across endpoint and etcd transport modules and replaces generic errors/logs with contextualized messages. Adds standardized error wrapping for etcd connection, lease, and key operations. Cancels the endpoint’s cancellation token on etcd registration failure. No public APIs or control flow are changed.

Changes

Cohort / File(s)	Summary
Endpoint discovery lib/runtime/src/component/endpoint.rs	Added COMPONENT_DISCOVERY_REGISTRATION_ERROR constant; updated error/log messages to include component/endpoint; on etcd kv_create failure, returns the specific error and cancels the related cancellation token.
ETCD transport (core) lib/runtime/src/transports/etcd.rs	Introduced ETCD error message templates; wrapped connection, lease, key-create, and txn paths with contextual errors (ETCD_CONNECTION_ERROR, ETCD_LEASE_ERROR, ETCD_KEY_CREATE_ERROR, ETCD_KEY_VALIDATE_ERROR, ETCD_KEY_OPERATION_ERROR); minor connect call tweak using cloned URL.
ETCD transport (lease) lib/runtime/src/transports/etcd/lease.rs	Added lease error constants (ETCD_LEASE_MAINTAIN_ERROR, ETCD_LEASE_REFRESH_ERROR, ETCD_LEASE_EXPIRED_ERROR, ETCD_LEASE_HEARTBEAT_ERROR); replaced generic logs/errors with structured messages; minor comment correction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my paw at logs made clear,
New error tunes are crisp to hear.
In burrows of etcd we hop,
With leases beating—never stop.
If keys misbehave, we name the fright—
Then nibble carrots by lamplight. 🥕

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description includes Overview, Details, and Related Issues sections but omits the “Where should the reviewer start?” section required by the repository template and the Related Issues section does not use an action keyword with a GitHub issue reference.	Please add the missing “Where should the reviewer start?” section to specify key files for review and format the Related Issues entry using an action keyword and a GitHub issue number (for example “Closes #123”).

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title Check	✅ Passed	The title clearly labels this PR as a chore focused on updating error messages, which accurately reflects the main change of introducing and standardizing error message constants across the endpoint and etcd modules.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}