Repository navigation
docs: document Dynamo Planner installation prerequisites - #231
Conversation
* fix(compliance): remediate OSRB filing requirements * fix(ci): stop archiving wheels in GitHub Actions * feat(ci): stage wheels in Artifactory * fix(ci): run wheel staging with bash * fix(codeowners): classify root dockerignore * docs(legal): reproduce Transformers license * fix(compliance): preserve provenance and legal payloads * fix(ci): validate wheels before staging * chore(codeowners): route compliance tests --------- (cherry picked from commit aab4635) Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com> Co-authored-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com>
* fix(generator): preserve Sweeper KV capacity [6738325] * fix(generator): preserve fixed capacity for TRT-LLM rc23 --------- (cherry picked from commit 58a5e18) Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com>
* chore: canonicalize repository governance files * fix(docs): keep packaged governance links resolvable --------- (cherry picked from commit d83e056) Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com> Co-authored-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com>
* ci: validate complete SPDX license identifiers * fix: make Jinja SPDX identifiers machine-readable * docs: add literal DCO sign-off command * docs: explain wheel-local legal file copies * docs: align replay parity reference with Apache-2.0 * fix: require closing SPDX block delimiters * fix: reject dangling SPDX comment delimiters --------- (cherry picked from commit 82de117) Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com> Co-authored-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com>
* fix(packaging): repair Linux wheels for manylinux 2.28 (#202) * fix(packaging): repair Linux wheels for manylinux 2.28 Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> * fix(ci): use bundled Python in manylinux jobs Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com> * test(packaging): verify manylinux repair behavior and pin Rust Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com> --------- Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com> Co-authored-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com> * fix(ci): build staged wheels for glibc 2.28 --------- Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com> Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com> Co-authored-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com>
Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com>
|
Self-review of The core YAML validates against this release's AIS schema and the Planner section against the Dynamo RC9 schema at Exact RC-wheel runtime verification is still pending. I sent Qun Chi the verification request and linked the PR in NVBug 6785216. Please verify the documented fresh-environment setup, 12 completed requests, and both output artifacts before closing the bug. This remains draft and is not yet ready for human review: NVIDIA runner admission requires the normal PR-vetter validation, and the full CI run is not present on this head. Maintainer approval and QA verification remain outstanding. No merge is requested. |
|
Retargeting to main as requested. The release branch has separate backport history, so a base-only change currently expands the comparison from the intended four documentation/example files to 116 files. I will reconcile this PR with current main, preserving main and applying only the original Planner documentation change, then validate the resulting four-file diff and current-head CI before merging. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (4)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. 📜 Recent review details🧰 Additional context used📓 Path-based instructions (3)Check commands, defaults, supported runtimes, public names, and claims against executable behavior.⚙️ CodeRabbit configuration file Files:
Read REVIEW.md before commenting.⚙️ CodeRabbit configuration file Files:
Before making any change under: `python/aisimulate/src/aiconfigurator/generator/**` MUST read: `python/aisimulate/.claude/rules/generator-development.md` Before making any change under `python/aisimulate/collector/**` MUST read: `python/ais...📄 CodeRabbit inference engine (AGENTS.md) Files:
🔀 Multi-repo context ai-dynamo/dynamo, ai-dynamo/aiconfiguratorLinked repositories findingsai-dynamo/dynamo
ai-dynamo/aiconfigurator
📝 SummaryRisk: Low for runtime code; medium for documentation accuracy. Human attention:
Changes
No runtime, dependency, or exported API changes are included. Evidence
Missing evidence and merge readiness
WalkthroughThe documentation updates describe compatible Dynamo installations, Planner dependency requirements, and optional adapter validation. A new example verifies Planner predictions with synthetic traffic, a Llama model configuration, and load-based scaling settings. ChangesDynamo Planner setup
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change adds documentation and a verification example without an established functional or operational regression; pending QA runtime verification is routine follow-up. 🚥 Pre-merge checks | ✅ 7 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (7 passed)
Full details: Cross-Layer ContractExplanation The PR adds a new Planner-enabled public CLI path, but no test consumes the added configuration or example. The changed-file inventory contains only README and example files. Existing tests cover generic adapter and runtime-hook contracts, not this exact planner schema, RC9 adapter compatibility, documented working directory, 12-request execution, or the two output files. The PR description also states that exact RC-wheel runtime verification remains pending. Therefore the new path is untested, and the compatibility and output claims lack repository-backed evidence. Resolution Add an automated integration test or CI job that uses the documented working directory and exact matching AISimulate and Dynamo artifacts. Install the pinned Planner requirements or matching image. Load the added YAML and model metadata through the public CLI, compile the
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
Signed-off-by: Jason Zhou (Engrg-Hardware 1) <jasonzho@nvidia.com>
|
@coderabbitai review |
|
|
Retargeted to Current-head validation:
GitHub retains the existing human approvals and reports APPROVED/MERGEABLE. The documentation-only patch was preserved during the merge with main. Exact RC-wheel end-to-end verification remains the stated QA follow-up in NVBug 6785216; it is not claimed by this CI result. Proceeding with the requested SHA-guarded squash merge into main. |
A basic
pip install aisimulate ai-dynamoinstallation can run Dynamo prediction but lacks dependencies required to loaddynamo.planner, includingscikit-learn.This PR targets
mainand addresses NVBug 6785216. It documents installing the full Planner requirements from the same Dynamo revision as the installed wheels, distinguishes exact RC artifacts from package versions, and identifies the matching Planner image as a prebuilt alternative.The four-file change includes a CPU-only CLI example with Planner load scaling, 12 synthetic requests, local model metadata, fixed timing, and fixed KV capacity. It documents the working directory and expected output files. No model weights, GPU, or Kubernetes cluster are needed.
Validation on head
0fafbbb2againstmain(612fbcf4):ffd7c1a90eb403c0d43911690c5c9b8457acd826using current AISimulate schema types.scikit-learn.Exact RC-wheel runtime verification remains pending with QA: confirm a clean installation, 12 completed requests, and both output files using the exact release artifacts. This PR does not claim that verification or close the bug. Current-head hosted CI and review are recorded in the checks and review activity.