Use YAML.safe_load_file instead of YAML.safe_load

[imobachgs]

Problem

For some reason that I have not been able to find, I am facing a problem
when loading the products definition:

bundler: failed to load command: bin/agamactl (bin/agamactl)
/usr/lib64/ruby/3.2.0/psych/parser.rb:62:in `_native_parse': (<unknown>): control characters are not allowed at line 1 column 1 (Psych::SyntaxError)
	from /usr/lib64/ruby/3.2.0/psych/parser.rb:62:in `parse'
	from /usr/lib64/ruby/3.2.0/psych.rb:455:in `parse_stream'
	from /usr/lib64/ruby/3.2.0/psych.rb:399:in `parse'
	from /usr/lib64/ruby/3.2.0/psych.rb:323:in `safe_load'
	from /home/suse/agama/service/lib/agama/product_reader.rb:63:in `load_file'
	from /home/suse/agama/service/lib/agama/product_reader.rb:50:in `block in load_products'
	from /home/suse/agama/service/lib/agama/product_reader.rb:48:in `each'
	from /home/suse/agama/service/lib/agama/product_reader.rb:48:in `each_with_object'
	from /home/suse/agama/service/lib/agama/product_reader.rb:48:in `load_products'
	from /home/suse/agama/service/lib/agama/config.rb:102:in `products'
	from /home/suse/agama/service/lib/agama/config.rb:83:in `data'
	from /home/suse/agama/service/lib/agama/config.rb:139:in `merge'
	from /home/suse/agama/service/lib/agama/config_reader.rb:89:in `block in config'
	from /home/suse/agama/service/lib/agama/config_reader.rb:89:in `each'
	from /home/suse/agama/service/lib/agama/config_reader.rb:89:in `config'
	from /home/suse/agama/service/lib/agama/config.rb:43:in `load'
	from /home/suse/agama/service/lib/agama/dbus/service_runner.rb:70:in `config'
	from /home/suse/agama/service/lib/agama/dbus/service_runner.rb:82:in `build_service'
	from /home/suse/agama/service/lib/agama/dbus/service_runner.rb:50:in `run'
	from bin/agamactl:65:in `start_service'
	from bin/agamactl:107:in `<top (required)>'

It only happens when running Agama under a root session. Funny enough, it did not happen when using sudo.

Solution

Use YAML.safe_load_file (instead of File.read + YAML.safe_load) fixes the issue for me.

Testing

• Tested manually

[coveralls]

coverage: 74.743% (+0.02%) from 74.724%
when pulling 4506d86 on safe-load-file
into 8b04ffc on master.