Skip to content

Apply ethernet config to dummy device #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imobachgs merged 1 commit into from
Dec 11, 2023
Merged

Apply ethernet config to dummy device #921

imobachgs merged 1 commit into from
Dec 11, 2023

Conversation

@jcronenberg
Copy link
Contributor

@jcronenberg jcronenberg commented Dec 8, 2023

Problem

Dummy has ethernet config inside NetworkManager, but is_ethernet() doesn't include dummy.

Solution

Add dummy to is_ethernet()

Testing

  • Tested manually

@jcronenberg jcronenberg mentioned this pull request Dec 8, 2023
Merged
@coveralls
Copy link

coveralls commented Dec 8, 2023

Coverage Status

coverage: 75.062% (+0.002%) from 75.06%
when pulling 1d07dbc on jcronenberg:dummy-ethernet
into 9145cfa on openSUSE:master.

@imobachgs imobachgs merged commit 7a1ca90 into agama-project:master Dec 11, 2023
@jcronenberg jcronenberg deleted the dummy-ethernet branch December 11, 2023 10:04
@jcronenberg jcronenberg mentioned this pull request Dec 11, 2023
Merged
@imobachgs imobachgs mentioned this pull request Dec 21, 2023
Merged
imobachgs added a commit that referenced this pull request Dec 21, 2023
@imobachgs
Update to release 7 (#947)
a1c7f33 
* #915
* #916
* #917
* #919
* #920
* #921
* #922
* #923
* #924
* #925
* #926
* #927
* #928
* #929
* #930
* #931
* #933
* #934
* #935
* #936
* #937
* #938
* #939
* #940
* #941
* #942
* #943
* #944
* #945
* #946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jcronenberg @coveralls @imobachgs