Skip to content

Conversation

@joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Dec 18, 2023

Problem

The input File system type in the dialog for adding/editing a file system shows an info icon. That icon is used to give some info about the possible file system types that can be selected. The info icon should not be shown if there is only a single option, in which the file system type is rendered as plain text instead of a selector. See #926.

Screenshot from 2023-12-18 10-57-42

Solution

Remove info icon when there is only one option.

NOTE: there is some problems associated to the info icon. For example, it takes the focus while navigating through the form. Moreover, it opens a popover, which could be a bit strange when it is used in a popup. Probably this info icon will be replaced by another approach.

Testing

  • Tested manually

Screenshots

Screenshot from 2023-12-18 10-51-33

@coveralls
Copy link

coveralls commented Dec 18, 2023

Coverage Status

coverage: 74.724%. remained the same
when pulling 56bf57b on joseivanlopez:fix-fs-info
into 275c770 on openSUSE:master.

@joseivanlopez joseivanlopez marked this pull request as ready for review December 18, 2023 10:59
@joseivanlopez joseivanlopez merged commit 8b04ffc into agama-project:master Dec 18, 2023
@imobachgs imobachgs mentioned this pull request Dec 21, 2023
imobachgs added a commit that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants