Skip to content

Packaging fixes#603

Merged
imobachgs merged 5 commits intomasterfrom
packaging-fixes
Jun 7, 2023
Merged

Packaging fixes#603
imobachgs merged 5 commits intomasterfrom
packaging-fixes

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs commented Jun 5, 2023

To be merged after #596 ☑️

  • Add the missing Network1.service definition.
  • Submit the Ruby package to systemsmanagement:Agama:Staging.
  • Drop rb_build_version. Not needed since boo#1208872 was fixed.

@imobachgs imobachgs marked this pull request as draft June 5, 2023 14:55
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 5178620387

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.686%

Totals Coverage Status
Change from base Build 5173879017: 0.0%
Covered Lines: 5396
Relevant Lines: 6890

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreidinger
Copy link
Copy Markdown
Contributor

@imobachgs what is also missing is removal of Language.service as it cannot be started now and completely replaced by Locale

@imobachgs
Copy link
Copy Markdown
Contributor Author

@imobachgs what is also missing is removal of Language.service as it cannot be started now and completely replaced by Locale

I dropped the old service in #608.

@imobachgs imobachgs marked this pull request as ready for review June 7, 2023 14:00
@imobachgs imobachgs merged commit 321f62c into master Jun 7, 2023
@imobachgs imobachgs deleted the packaging-fixes branch June 7, 2023 14:03
@imobachgs imobachgs mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants