Skip to content

Drop Language1 service#608

Merged
imobachgs merged 4 commits intomasterfrom
drop-language1-service
Jun 7, 2023
Merged

Drop Language1 service#608
imobachgs merged 4 commits intomasterfrom
drop-language1-service

Conversation

@imobachgs
Copy link
Copy Markdown
Contributor

Problem

The repository still contains code and documentation references of the old Ruby-based Language1 service.

Solution

  • Drop the Ruby code.
  • Update the documents.
  • Update the Rust code (the Locale1 is not used yet).

Notes

  • zbus already exports the methods/properties documentation in the XML introspection. What do you think we should do about this?

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 7, 2023

Pull Request Test Coverage Report for Build 5196382113

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 75.9%

Files with Coverage Reduction New Missed Lines %
service/lib/agama/errors.rb 5 0%
Totals Coverage Status
Change from base Build 5173879017: 0.2%
Covered Lines: 5337
Relevant Lines: 6790

💛 - Coveralls

@imobachgs imobachgs merged commit 6a995a1 into master Jun 7, 2023
@imobachgs imobachgs deleted the drop-language1-service branch June 7, 2023 08:53
@imobachgs imobachgs mentioned this pull request Jun 7, 2023
@imobachgs imobachgs mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants