Conversation
Contributor
Author
|
I've tried to register different objects per Users1 and Agama1. However d-feet shows the same object for both of them
|
Pull Request Test Coverage Report for Build 5199874486
💛 - Coveralls |
mvidner
reviewed
May 30, 2023
2 tasks
Merged
imobachgs
requested changes
Jun 7, 2023
Contributor
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
It looks good. Please, add an entry to the changes file referencing this PR. Thanks!
Contributor
|
Please, fix the conflicts too. |
Otherwise our main loop would briefly expose an empty object tree, producing "D-Bus Error" in the web UI This needs DBus::BusConnection#request_name
Will be switched to 0.23.0.beta1 within 1 hour ;-)
Also relax the dependency to allow anything < 1.0 On the assumption that its maintainer (myself) will be quick to fix any API problems that may occur on version upgrades.
imobachgs
reviewed
Jun 7, 2023
Contributor
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
Almost LGTM :-) Just two small things.
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
imobachgs
approved these changes
Jun 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Purpose is to save some resources. As there is low benefit from having users in separate process, here it patched to run in same process as the manager service.
Solution
Short description of the fix.
Testing
Screenshots
If the fix affects the UI attach some screenshots here.