Conversation
Contributor
|
It looks good. We can merge once #443 is merged. Thanks! |
imobachgs
approved these changes
Mar 3, 2023
dgdavid
added a commit
that referenced
this pull request
Mar 14, 2025
## Problem Although [it was introduced](#448) to help keep the code free of spelling typos, it [has been deactivated for a while](dc83f67) at CI. *Short description of the original problem.* - *Bugzilla link* - *openQA link* - *Links to other related pull requests* ## Solution While still useful for spotting spelling mistakes (see #2157), developers can run it locally with their own configuration if desired. ## Additional note https://github.com/agama-project/agama/blob/master/web/src/assets/fonts.scss file still having a cspell:ignore comment because the file is actually dead code that will be removed in a separated pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While working in #443, I found few typos in the code, a bunch of them sent by myself 😅 Sadly, typos are easy to type but so hard to spot. And not only for me, read https://www.scienceabc.com/humans/why-is-it-so-difficult-to-spot-your-own-typos.html.
Solution
Add a spell checker to help us to detect them. Specifically cspell.
Notes
add-missing-sectionsbranch. If we're willing to include them inmaster, I can adapt them after mentioned branch got merged.Image borrowed from the article.