Merged
Conversation
Because it does not work as well as expected. E.g., "Hardaware" and "Needfed" are considered right. See streetsidesoftware/cspell#317 and https://github.com/streetsidesoftware/cspell/labels/allowCompoundWords
Instead of ignoring words. According to streetsidesoftware/cspell#4229 it's a better approach when dealing with large words list. Using an inline dictionary, which is supported since streetsidesoftware/cspell#4135
imobachgs
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Thanks to @imobachgs's review at #462 (comment), I realize that something was not working as expected with the check spelling task introduced in #448
Basically, using the
allowCompoundWords: truegoes to let go some typos.Solution
allowCompoundWordssettings to falseignoredWordslist is too long already