[web] Move each section to its own page#443
Merged
Conversation
Co-authored-by: David Díaz González <dgonzalez@suse.de>
Co-authored-by: David Díaz González <dgonzalez@suse.de>
Co-authored-by: David Díaz González <dgonzalez@suse.de>
Co-authored-by: David Díaz González <dgonzalez@suse.de>
Co-authored-by: David Díaz González <dgonzalez@suse.de>
Co-authored-by: David Díaz González <dgonzalez@suse.de>
Co-authored-by: David Díaz González <dgonzalez@suse.de>
It helps at the time to change our mind about how emphasized text should looks like. By now it's a compact PF4/Label.
Until we manage to have them working as expected by importing first the needed typedef / interfaces from PatternFly.
dgdavid
force-pushed
the
add-missing-sections
branch
from
87a0fac to
a1ce704
Compare
dgdavid
force-pushed
the
add-missing-sections
branch
from
a1ce704 to
199b4f2
Compare
imobachgs
reviewed
Mar 2, 2023
Contributor
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
Great job! Thanks a lot. Just check the headers of the users components.
dgdavid
force-pushed
the
add-missing-sections
branch
from
bd83ac2 to
4755b87
Compare
This was referenced Mar 2, 2023
imobachgs
approved these changes
Mar 3, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
D-Installer continues to evolve and the UI approach used for prototyping the first version needs to be rethought to have a consistent Overview page rather than a bunch of cluttering links and modal dialogs for each available setting.
Solution
At of now, we believe that utilizing navigation and creating dedicated pages for each section is the most natural approach.. It allows having a more fluent, self-explanatory UI and reduces the overuse of modal dialogs.
As many others in this alpha development phase, this PR can be seen as a first step towards that direction. There are still parts to be relocated better (like a network details and settings, which probably deserve a separate page too), but more time and feedback is needed to have a better picture of next changes in that regard.
Testing
Caveats
User dialog has been prepared to allow user edition. However, at this time it will fail because the backend is not ready this use case.
The team is aware of this and we agree to move this PR on and make a new one later for fixing the issue.
Screenshots
The UI has been changed a lot in this PR. Therefore, taking screenshots of all of them manually is not optimal. Rather, please switch to the
add-missing-sectionsbranch and navigate through the available pages and options. Your feedback is greatly appreciated, but it would be helpful if you sent it as a detailed issue so we can analyze, sort, and prioritize it.