Conversation
joseivanlopez
force-pushed
the
extend-users-dbus-api
branch
from
0dd8d51 to
d11abf8
Compare
joseivanlopez
force-pushed
the
extend-users-dbus-api
branch
from
a2e2313 to
6013463
Compare
Once the user is defined, it can be edited changing or preserving the password. This is convenient to allow changing the user data without having to retype the password.
dgdavid
reviewed
Mar 3, 2023
| removeUser: removeUserFn, | ||
| getUser: jest.fn().mockResolvedValue(user), | ||
| removeUser: removeUserFn, | ||
| onUsersChange: onUsersChangeFn |
Contributor
There was a problem hiding this comment.
Funny: no idea how I manage to do and send this change. Anyway, It does not hurt, so I'd keep it is there is no other change to send.
imobachgs
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is no way to edit the first user without providing the password again. Although it may seem inconsequential, it's a bit annoying to have to retype the password and confirmation to fix a typo in the username.
Solution
Extend the D-Bus API for providing the already set password and to adapt the UI to send updated password only when the user has chosen to change it.
Testing
Related to #443 where the form to allow user edition was set.