Add diagnostic queries #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These list: - Remote flow source. - UI5 specific sinks for XSS. - UI5 specific sinks for log injection. These help with determining if we are missing any for a given codebase.
Because the pack now contains diagnostic queries we want to by default only execute the security queries. The suites follow the standard library convention where the default suite is suited for running in code scanning. This means only security queries with precision high or very high. Currently this excludes the log injection query because its precision is medium. The security extended suite includes the log injection query.
rvermeulen
force-pushed
the
rvermeulen/diagnostics
branch
from
893fbe7 to
53855a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagnostic queries can be used to debug possible missing sources and sinks.
The suite
sap-ui5-diagnostics.qlscan be used to execute them and collect their results in a Sarif file.Because the query set now contains non-security queries, the default behavior is changed using suites that follow the standard library convention.
The default suite
sap-ui5-codescanning.qlsonly execute security queries with precision high and very-high. This will exclude the log injection query.The suite
sap-ui5-security-extended.qlswill execute all security queries with precision medium to very high.