Skip to content

Add diagnostic queries #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Add diagnostic queries #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c40a3b
Add diagnostic queries
rvermeulen Oct 6, 2023
7bb909e
Add codeql suites and set default suite
rvermeulen Oct 6, 2023
53855a0
Replace log sink test with diagnostic query
rvermeulen Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions javascript/frameworks/ui5/src/Diagnostics/ListHtmlSinks.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/**
* @name SAP UI5 Html injection sinks
* @description List all SAP UI5 Html injection sinks
* @kind problem
* @problem.severity info
* @precision high
* @id js/ui5-list-html-injection-sinks
* @tags diagnostics
*/

import javascript
import advanced_security.javascript.frameworks.ui5.UI5DataFlow

from DataFlow::Node sink, string kind
where
sink = ModelOutput::getASinkNode(kind).asSink() and
kind = "ui5-html-injection"
or
sink instanceof UI5DataFlow::UI5ModelHtmlISink and
kind = "ui5-model-sink"
select sink, "SAP UI5 Html injection sink with kind: " + kind
17 changes: 17 additions & 0 deletions javascript/frameworks/ui5/src/Diagnostics/ListLogInjectionSinks.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/**
* @name SAP UI5 log injection sinks
* @description List all SAP UI5 log injection sinks
* @kind problem
* @problem.severity info
* @precision high
* @id js/ui5-list-log-injection-sinks
* @tags diagnostics
*/

import javascript

from DataFlow::Node sink, string kind
where
sink = ModelOutput::getASinkNode(kind).asSink() and
kind = "ui5-log-injection"
select sink, "SAP UI5 log injection sink with kind: " + kind
16 changes: 16 additions & 0 deletions javascript/frameworks/ui5/src/Diagnostics/ListRemoteFlowSources.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/**
* @name List all remote sources
* @description List all remote sources
* @kind problem
* @problem.severity info
* @precision high
* @id js/ui5-list-remote-flow-sources
* @tags diagnostics
*/

import javascript
import advanced_security.javascript.frameworks.ui5.UI5DataFlow

from RemoteFlowSource source, string type
where type = source.getSourceType()
select source, "Remote flow source of type: " + type
13 changes: 13 additions & 0 deletions javascript/frameworks/ui5/src/codeql-suites/sap-ui5-code-scanning.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
- description: SAP UI5 Code Scanning Suite
- queries: .
- include:
tags contain: security
kind:
- problem
- path-problem
precision:
- high
- very-high
problem.severity:
- warning
- error
4 changes: 4 additions & 0 deletions javascript/frameworks/ui5/src/codeql-suites/sap-ui5-diagnostics.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- description: SAP UI5 Code Scanning Suite
- queries: .
- include:
tags contain: diagnostics
14 changes: 14 additions & 0 deletions javascript/frameworks/ui5/src/codeql-suites/sap-ui5-security-extended.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
- description: SAP UI5 Security Extended Suite
- queries: .
- include:
tags contain: security
kind:
- problem
- path-problem
precision:
- medium
- high
- very-high
problem.severity:
- warning
- error
1 change: 1 addition & 0 deletions javascript/frameworks/ui5/src/qlpack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ dependencies:
codeql/javascript-all: "^0.6.3"
advanced-security/javascript-sap-ui5-models: "^0.2.0"
advanced-security/javascript-sap-ui5-all: "^0.2.0"
default-suite-file: codeql-suites/sap-ui5-code-scanning.qls
130 changes: 56 additions & 74 deletions javascript/frameworks/ui5/test/models/sink/logSinkTest.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,74 +1,56 @@
| sink.js:20:38:20:42 | code0 | code0 |
| sink.js:20:45:20:49 | code1 | code1 |
| sink.js:20:52:20:56 | code2 | code2 |
| sink.js:21:38:21:42 | code0 | code0 |
| sink.js:21:45:21:49 | code1 | code1 |
| sink.js:21:52:21:56 | code2 | code2 |
| sink.js:23:40:23:44 | code0 | code0 |
| sink.js:23:47:23:51 | code1 | code1 |
| sink.js:23:54:23:58 | code2 | code2 |
| sink.js:25:37:25:41 | code0 | code0 |
| sink.js:25:44:25:48 | code1 | code1 |
| sink.js:25:51:25:55 | code2 | code2 |
| sink.js:27:38:27:42 | code0 | code0 |
| sink.js:27:45:27:49 | code1 | code1 |
| sink.js:27:52:27:56 | code2 | code2 |
| sink.js:29:38:29:42 | code0 | code0 |
| sink.js:29:45:29:49 | code1 | code1 |
| sink.js:29:52:29:56 | code2 | code2 |
| sink.js:33:27:33:31 | code0 | code0 |
| sink.js:33:34:33:38 | code1 | code1 |
| sink.js:33:41:33:45 | code2 | code2 |
| sink.js:35:27:35:31 | code0 | code0 |
| sink.js:35:34:35:38 | code1 | code1 |
| sink.js:35:41:35:45 | code2 | code2 |
| sink.js:37:29:37:33 | code0 | code0 |
| sink.js:37:36:37:40 | code1 | code1 |
| sink.js:37:43:37:47 | code2 | code2 |
| sink.js:39:26:39:30 | code0 | code0 |
| sink.js:39:33:39:37 | code1 | code1 |
| sink.js:39:40:39:44 | code2 | code2 |
| sink.js:41:27:41:31 | code0 | code0 |
| sink.js:41:34:41:38 | code1 | code1 |
| sink.js:41:41:41:45 | code2 | code2 |
| sink.js:43:27:43:31 | code0 | code0 |
| sink.js:43:34:43:38 | code1 | code1 |
| sink.js:43:41:43:45 | code2 | code2 |
| sink.js:45:42:45:46 | code1 | code1 |
| sink.js:74:36:74:40 | code0 | code0 |
| sink.js:74:43:74:47 | code1 | code1 |
| sink.js:74:50:74:54 | code2 | code2 |
| sink.js:75:36:75:40 | code0 | code0 |
| sink.js:75:43:75:47 | code1 | code1 |
| sink.js:75:50:75:54 | code2 | code2 |
| sink.js:76:38:76:42 | code0 | code0 |
| sink.js:76:45:76:49 | code1 | code1 |
| sink.js:76:52:76:56 | code2 | code2 |
| sink.js:77:35:77:39 | code0 | code0 |
| sink.js:77:42:77:46 | code1 | code1 |
| sink.js:77:49:77:53 | code2 | code2 |
| sink.js:78:36:78:40 | code0 | code0 |
| sink.js:78:43:78:47 | code1 | code1 |
| sink.js:78:50:78:54 | code2 | code2 |
| sink.js:79:36:79:40 | code0 | code0 |
| sink.js:79:43:79:47 | code1 | code1 |
| sink.js:79:50:79:54 | code2 | code2 |
| sink.js:80:27:80:31 | code0 | code0 |
| sink.js:80:34:80:38 | code1 | code1 |
| sink.js:80:41:80:45 | code2 | code2 |
| sink.js:81:27:81:31 | code0 | code0 |
| sink.js:81:34:81:38 | code1 | code1 |
| sink.js:81:41:81:45 | code2 | code2 |
| sink.js:82:29:82:33 | code0 | code0 |
| sink.js:82:36:82:40 | code1 | code1 |
| sink.js:82:43:82:47 | code2 | code2 |
| sink.js:83:26:83:30 | code0 | code0 |
| sink.js:83:33:83:37 | code1 | code1 |
| sink.js:83:40:83:44 | code2 | code2 |
| sink.js:84:27:84:31 | code0 | code0 |
| sink.js:84:34:84:38 | code1 | code1 |
| sink.js:84:41:84:45 | code2 | code2 |
| sink.js:85:27:85:31 | code0 | code0 |
| sink.js:85:34:85:38 | code1 | code1 |
| sink.js:85:41:85:45 | code2 | code2 |
| sink.js:86:40:86:44 | code1 | code1 |
| sink.js:20:38:20:42 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:20:45:20:49 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:20:52:20:56 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:21:38:21:42 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:21:45:21:49 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:21:52:21:56 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:23:40:23:44 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:23:47:23:51 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:23:54:23:58 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:25:37:25:41 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:25:44:25:48 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:25:51:25:55 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:27:38:27:42 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:27:45:27:49 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:27:52:27:56 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:29:38:29:42 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:29:45:29:49 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:29:52:29:56 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:33:27:33:31 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:33:34:33:38 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:33:41:33:45 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:35:27:35:31 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:35:34:35:38 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:35:41:35:45 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:37:29:37:33 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:37:36:37:40 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:37:43:37:47 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:39:26:39:30 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:39:33:39:37 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:39:40:39:44 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:41:27:41:31 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:41:34:41:38 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:41:41:41:45 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:43:27:43:31 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:43:34:43:38 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:43:41:43:45 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:45:42:45:46 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:74:36:74:40 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:74:43:74:47 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:74:50:74:54 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:75:36:75:40 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:75:43:75:47 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:75:50:75:54 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:76:38:76:42 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:76:45:76:49 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:76:52:76:56 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:77:35:77:39 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:77:42:77:46 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:77:49:77:53 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:78:36:78:40 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:78:43:78:47 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:78:50:78:54 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:79:36:79:40 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:79:43:79:47 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:79:50:79:54 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
| sink.js:86:40:86:44 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
17 changes: 0 additions & 17 deletions javascript/frameworks/ui5/test/models/sink/logSinkTest.ql
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions javascript/frameworks/ui5/test/models/sink/logSinkTest.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Diagnostics/ListLogInjectionSinks.ql