Skip to content

Commit 893fbe7

Browse files
rvermeulenrvermeulen
committed
Replace model tests with diagnostic queries
1 parent 7bb909e commit 893fbe7

File tree

7 files changed

+87
-136
lines changed

7 files changed

+87
-136
lines changed

‎javascript/frameworks/ui5/src/Diagnostics/ListRemoteFlowSources.ql‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
*/
1010

1111
import javascript
12+
import advanced_security.javascript.frameworks.ui5.UI5DataFlow
1213

1314
from RemoteFlowSource source, string type
1415
where type = source.getSourceType()

‎javascript/frameworks/ui5/test/models/sink/logSinkTest.expected‎

Lines changed: 56 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -1,74 +1,56 @@
1-
| sink.js:20:38:20:42 | code0 | code0 |
2-
| sink.js:20:45:20:49 | code1 | code1 |
3-
| sink.js:20:52:20:56 | code2 | code2 |
4-
| sink.js:21:38:21:42 | code0 | code0 |
5-
| sink.js:21:45:21:49 | code1 | code1 |
6-
| sink.js:21:52:21:56 | code2 | code2 |
7-
| sink.js:23:40:23:44 | code0 | code0 |
8-
| sink.js:23:47:23:51 | code1 | code1 |
9-
| sink.js:23:54:23:58 | code2 | code2 |
10-
| sink.js:25:37:25:41 | code0 | code0 |
11-
| sink.js:25:44:25:48 | code1 | code1 |
12-
| sink.js:25:51:25:55 | code2 | code2 |
13-
| sink.js:27:38:27:42 | code0 | code0 |
14-
| sink.js:27:45:27:49 | code1 | code1 |
15-
| sink.js:27:52:27:56 | code2 | code2 |
16-
| sink.js:29:38:29:42 | code0 | code0 |
17-
| sink.js:29:45:29:49 | code1 | code1 |
18-
| sink.js:29:52:29:56 | code2 | code2 |
19-
| sink.js:33:27:33:31 | code0 | code0 |
20-
| sink.js:33:34:33:38 | code1 | code1 |
21-
| sink.js:33:41:33:45 | code2 | code2 |
22-
| sink.js:35:27:35:31 | code0 | code0 |
23-
| sink.js:35:34:35:38 | code1 | code1 |
24-
| sink.js:35:41:35:45 | code2 | code2 |
25-
| sink.js:37:29:37:33 | code0 | code0 |
26-
| sink.js:37:36:37:40 | code1 | code1 |
27-
| sink.js:37:43:37:47 | code2 | code2 |
28-
| sink.js:39:26:39:30 | code0 | code0 |
29-
| sink.js:39:33:39:37 | code1 | code1 |
30-
| sink.js:39:40:39:44 | code2 | code2 |
31-
| sink.js:41:27:41:31 | code0 | code0 |
32-
| sink.js:41:34:41:38 | code1 | code1 |
33-
| sink.js:41:41:41:45 | code2 | code2 |
34-
| sink.js:43:27:43:31 | code0 | code0 |
35-
| sink.js:43:34:43:38 | code1 | code1 |
36-
| sink.js:43:41:43:45 | code2 | code2 |
37-
| sink.js:45:42:45:46 | code1 | code1 |
38-
| sink.js:74:36:74:40 | code0 | code0 |
39-
| sink.js:74:43:74:47 | code1 | code1 |
40-
| sink.js:74:50:74:54 | code2 | code2 |
41-
| sink.js:75:36:75:40 | code0 | code0 |
42-
| sink.js:75:43:75:47 | code1 | code1 |
43-
| sink.js:75:50:75:54 | code2 | code2 |
44-
| sink.js:76:38:76:42 | code0 | code0 |
45-
| sink.js:76:45:76:49 | code1 | code1 |
46-
| sink.js:76:52:76:56 | code2 | code2 |
47-
| sink.js:77:35:77:39 | code0 | code0 |
48-
| sink.js:77:42:77:46 | code1 | code1 |
49-
| sink.js:77:49:77:53 | code2 | code2 |
50-
| sink.js:78:36:78:40 | code0 | code0 |
51-
| sink.js:78:43:78:47 | code1 | code1 |
52-
| sink.js:78:50:78:54 | code2 | code2 |
53-
| sink.js:79:36:79:40 | code0 | code0 |
54-
| sink.js:79:43:79:47 | code1 | code1 |
55-
| sink.js:79:50:79:54 | code2 | code2 |
56-
| sink.js:80:27:80:31 | code0 | code0 |
57-
| sink.js:80:34:80:38 | code1 | code1 |
58-
| sink.js:80:41:80:45 | code2 | code2 |
59-
| sink.js:81:27:81:31 | code0 | code0 |
60-
| sink.js:81:34:81:38 | code1 | code1 |
61-
| sink.js:81:41:81:45 | code2 | code2 |
62-
| sink.js:82:29:82:33 | code0 | code0 |
63-
| sink.js:82:36:82:40 | code1 | code1 |
64-
| sink.js:82:43:82:47 | code2 | code2 |
65-
| sink.js:83:26:83:30 | code0 | code0 |
66-
| sink.js:83:33:83:37 | code1 | code1 |
67-
| sink.js:83:40:83:44 | code2 | code2 |
68-
| sink.js:84:27:84:31 | code0 | code0 |
69-
| sink.js:84:34:84:38 | code1 | code1 |
70-
| sink.js:84:41:84:45 | code2 | code2 |
71-
| sink.js:85:27:85:31 | code0 | code0 |
72-
| sink.js:85:34:85:38 | code1 | code1 |
73-
| sink.js:85:41:85:45 | code2 | code2 |
74-
| sink.js:86:40:86:44 | code1 | code1 |
1+
| sink.js:20:38:20:42 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
2+
| sink.js:20:45:20:49 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
3+
| sink.js:20:52:20:56 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
4+
| sink.js:21:38:21:42 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
5+
| sink.js:21:45:21:49 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
6+
| sink.js:21:52:21:56 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
7+
| sink.js:23:40:23:44 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
8+
| sink.js:23:47:23:51 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
9+
| sink.js:23:54:23:58 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
10+
| sink.js:25:37:25:41 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
11+
| sink.js:25:44:25:48 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
12+
| sink.js:25:51:25:55 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
13+
| sink.js:27:38:27:42 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
14+
| sink.js:27:45:27:49 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
15+
| sink.js:27:52:27:56 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
16+
| sink.js:29:38:29:42 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
17+
| sink.js:29:45:29:49 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
18+
| sink.js:29:52:29:56 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
19+
| sink.js:33:27:33:31 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
20+
| sink.js:33:34:33:38 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
21+
| sink.js:33:41:33:45 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
22+
| sink.js:35:27:35:31 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
23+
| sink.js:35:34:35:38 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
24+
| sink.js:35:41:35:45 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
25+
| sink.js:37:29:37:33 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
26+
| sink.js:37:36:37:40 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
27+
| sink.js:37:43:37:47 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
28+
| sink.js:39:26:39:30 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
29+
| sink.js:39:33:39:37 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
30+
| sink.js:39:40:39:44 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
31+
| sink.js:41:27:41:31 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
32+
| sink.js:41:34:41:38 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
33+
| sink.js:41:41:41:45 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
34+
| sink.js:43:27:43:31 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
35+
| sink.js:43:34:43:38 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
36+
| sink.js:43:41:43:45 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
37+
| sink.js:45:42:45:46 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
38+
| sink.js:74:36:74:40 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
39+
| sink.js:74:43:74:47 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
40+
| sink.js:74:50:74:54 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
41+
| sink.js:75:36:75:40 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
42+
| sink.js:75:43:75:47 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
43+
| sink.js:75:50:75:54 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
44+
| sink.js:76:38:76:42 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
45+
| sink.js:76:45:76:49 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
46+
| sink.js:76:52:76:56 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
47+
| sink.js:77:35:77:39 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
48+
| sink.js:77:42:77:46 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
49+
| sink.js:77:49:77:53 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
50+
| sink.js:78:36:78:40 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
51+
| sink.js:78:43:78:47 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
52+
| sink.js:78:50:78:54 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
53+
| sink.js:79:36:79:40 | code0 | SAP UI5 log injection sink with kind: ui5-log-injection |
54+
| sink.js:79:43:79:47 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |
55+
| sink.js:79:50:79:54 | code2 | SAP UI5 log injection sink with kind: ui5-log-injection |
56+
| sink.js:86:40:86:44 | code1 | SAP UI5 log injection sink with kind: ui5-log-injection |

‎javascript/frameworks/ui5/test/models/sink/logSinkTest.ql‎

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎javascript/frameworks/ui5/test/models/sink/logSinkTest.qlref‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Diagnostics/ListLogInjectionSinks.ql

‎javascript/frameworks/ui5/test/models/source/sourceTest.expected‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
1-
| source.js:25:17:25:25 | obj.value | obj.value |
2-
| source.js:27:17:27:30 | obj.getValue() | obj.getValue() |
3-
| source.js:29:17:29:25 | obj.value | obj.value |
4-
| source.js:31:17:31:30 | obj.getValue() | obj.getValue() |
5-
| source.js:33:17:33:25 | obj.value | obj.value |
6-
| source.js:35:17:35:30 | obj.getValue() | obj.getValue() |
7-
| source.js:37:17:37:25 | obj.value | obj.value |
8-
| source.js:39:17:39:30 | obj.getValue() | obj.getValue() |
9-
| source.js:41:17:41:25 | obj.value | obj.value |
10-
| source.js:43:17:43:30 | obj.getValue() | obj.getValue() |
11-
| source.js:45:17:45:25 | obj.value | obj.value |
12-
| source.js:47:17:47:30 | obj.getValue() | obj.getValue() |
13-
| source.js:49:17:49:25 | obj.value | obj.value |
14-
| source.js:51:17:51:37 | obj.get ... Value() | obj.get ... Value() |
15-
| source.js:53:17:53:25 | obj.value | obj.value |
16-
| source.js:55:17:55:30 | obj.getValue() | obj.getValue() |
17-
| source.js:57:17:57:51 | jQuery. ... ).get() | jQuery. ... ).get() |
18-
| source.js:59:17:59:37 | jQuery. ... cHead() | jQuery. ... cHead() |
19-
| source.js:61:17:61:36 | jQuery.sap.syncGet() | jQuery.sap.syncGet() |
20-
| source.js:63:17:63:40 | jQuery. ... tText() | jQuery. ... tText() |
21-
| source.js:65:17:65:37 | jQuery. ... cPost() | jQuery. ... cPost() |
22-
| source.js:67:17:67:41 | jQuery. ... tText() | jQuery. ... tText() |
23-
| source.js:69:17:69:52 | UriPara ... ).get() | UriPara ... ).get() |
24-
| source.js:70:17:70:55 | UriPara ... etAll() | UriPara ... etAll() |
25-
| source.js:73:17:73:25 | obj.get() | obj.get() |
26-
| source.js:74:17:74:28 | obj.getAll() | obj.getAll() |
27-
| source.js:76:17:76:28 | obj.getAll() | obj.getAll() |
28-
| source.js:78:17:78:25 | obj.get() | obj.get() |
1+
| source.js:25:17:25:25 | obj.value | Remote flow source of type: Remote flow |
2+
| source.js:27:17:27:30 | obj.getValue() | Remote flow source of type: Remote flow |
3+
| source.js:29:17:29:25 | obj.value | Remote flow source of type: Remote flow |
4+
| source.js:31:17:31:30 | obj.getValue() | Remote flow source of type: Remote flow |
5+
| source.js:33:17:33:25 | obj.value | Remote flow source of type: Remote flow |
6+
| source.js:35:17:35:30 | obj.getValue() | Remote flow source of type: Remote flow |
7+
| source.js:37:17:37:25 | obj.value | Remote flow source of type: Remote flow |
8+
| source.js:39:17:39:30 | obj.getValue() | Remote flow source of type: Remote flow |
9+
| source.js:41:17:41:25 | obj.value | Remote flow source of type: Remote flow |
10+
| source.js:43:17:43:30 | obj.getValue() | Remote flow source of type: Remote flow |
11+
| source.js:45:17:45:25 | obj.value | Remote flow source of type: Remote flow |
12+
| source.js:47:17:47:30 | obj.getValue() | Remote flow source of type: Remote flow |
13+
| source.js:49:17:49:25 | obj.value | Remote flow source of type: Remote flow |
14+
| source.js:51:17:51:37 | obj.get ... Value() | Remote flow source of type: Remote flow |
15+
| source.js:53:17:53:25 | obj.value | Remote flow source of type: Remote flow |
16+
| source.js:55:17:55:30 | obj.getValue() | Remote flow source of type: Remote flow |
17+
| source.js:57:17:57:51 | jQuery. ... ).get() | Remote flow source of type: Remote flow |
18+
| source.js:59:17:59:37 | jQuery. ... cHead() | Remote flow source of type: Remote flow |
19+
| source.js:61:17:61:36 | jQuery.sap.syncGet() | Remote flow source of type: Remote flow |
20+
| source.js:63:17:63:40 | jQuery. ... tText() | Remote flow source of type: Remote flow |
21+
| source.js:65:17:65:37 | jQuery. ... cPost() | Remote flow source of type: Remote flow |
22+
| source.js:67:17:67:41 | jQuery. ... tText() | Remote flow source of type: Remote flow |
23+
| source.js:69:17:69:52 | UriPara ... ).get() | Remote flow source of type: Remote flow |
24+
| source.js:70:17:70:55 | UriPara ... etAll() | Remote flow source of type: Remote flow |
25+
| source.js:73:17:73:25 | obj.get() | Remote flow source of type: Remote flow |
26+
| source.js:74:17:74:28 | obj.getAll() | Remote flow source of type: Remote flow |
27+
| source.js:76:17:76:28 | obj.getAll() | Remote flow source of type: Remote flow |
28+
| source.js:78:17:78:25 | obj.get() | Remote flow source of type: Remote flow |

‎javascript/frameworks/ui5/test/models/source/sourceTest.ql‎

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎javascript/frameworks/ui5/test/models/source/sourceTest.qlref‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Diagnostics/ListRemoteFlowSources.ql

0 commit comments

Comments
 (0)