Landscape improvements #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in landscape mode
- Event log is now hidden by default and can be configured via settings, it can also be toggled - Navigation bar is now hidden by default and can be toggled
- Animating top constraint instead of height of the headerView to avoid breaking constraints - Added headerOffset to other views that show ads
Closed
inderdhir
reviewed
Jul 18, 2023
inderdhir
previously approved these changes
Jul 18, 2023
|
I just changed the base to develop from main @inderdhir @brugg |
brugg
previously approved these changes
Jul 24, 2023
# Conflicts: # Application/Sources/Rendering/NimbusAdManager.swift
|
I just merged |
brugg
approved these changes
Jul 24, 2023
brugg
added a commit
that referenced
this pull request
Jul 26, 2023
* added cloning instructions (#56) * encryption declaration (#55) * added width/height constraints to fix the click action for manually rendered banner (#58) * Landscape improvements (#54) * different landscape ad sizes, adjusted constraints to improve the UI in landscape mode * helper renamed to nimbusIsLandscape * - Refactored settings using categorized enums - Event log is now hidden by default and can be configured via settings, it can also be toggled - Navigation bar is now hidden by default and can be toggled * - Logger padding - Animating top constraint instead of height of the headerView to avoid breaking constraints - Added headerOffset to other views that show ads * simplified using toggle() --------- Co-authored-by: Bruno Bruggemann <[email protected]> * Update Info.plist for DP rewarded id (#61) (#62) Co-authored-by: Inder Dhir <[email protected]> * Update Nimbus SDK to v2.13.0 (#63) --------- Co-authored-by: Standa Musil <[email protected]> Co-authored-by: Inder Dhir <[email protected]>
brugg
added a commit
that referenced
this pull request
Aug 3, 2023
* added cloning instructions (#56) * encryption declaration (#55) * added width/height constraints to fix the click action for manually rendered banner (#58) * Landscape improvements (#54) * different landscape ad sizes, adjusted constraints to improve the UI in landscape mode * helper renamed to nimbusIsLandscape * - Refactored settings using categorized enums - Event log is now hidden by default and can be configured via settings, it can also be toggled - Navigation bar is now hidden by default and can be toggled * - Logger padding - Animating top constraint instead of height of the headerView to avoid breaking constraints - Added headerOffset to other views that show ads * simplified using toggle() --------- Co-authored-by: Bruno Bruggemann <[email protected]> * Update Info.plist for DP rewarded id (#61) (#62) Co-authored-by: Inder Dhir <[email protected]> * Update Nimbus SDK to v2.13.0 (#63) * Update Sample App to Nimbus v2.14.0 --------- Co-authored-by: Standa Musil <[email protected]> Co-authored-by: Inder Dhir <[email protected]>
brugg
added a commit
that referenced
this pull request
Aug 25, 2023
* added cloning instructions (#56) * encryption declaration (#55) * added width/height constraints to fix the click action for manually rendered banner (#58) * Landscape improvements (#54) * different landscape ad sizes, adjusted constraints to improve the UI in landscape mode * helper renamed to nimbusIsLandscape * - Refactored settings using categorized enums - Event log is now hidden by default and can be configured via settings, it can also be toggled - Navigation bar is now hidden by default and can be toggled * - Logger padding - Animating top constraint instead of height of the headerView to avoid breaking constraints - Added headerOffset to other views that show ads * simplified using toggle() --------- Co-authored-by: Bruno Bruggemann <[email protected]> * Update Info.plist for DP rewarded id (#61) (#62) Co-authored-by: Inder Dhir <[email protected]> * Update Nimbus SDK to v2.13.0 (#63) * Admob changes develop (#66) * Add support for DP AdMob # Conflicts: # Application/Sources/Mediation/AdMob.swift * Update sample app for AdMob # Conflicts: # Application/Sources/Navigation.swift * Show relevant demos for AdMob/GAM * Show relevant demos for AdMob/GAM * Fix Admob impl * updated test renderer to trim white spaces and newlines, always render a static ad if the markup isn't a video (#67) * replaced test renderer's textField with a textView to allow scrolling and easier manipulation with the ad markup (#68) * Update Sample App to Nimbus v2.14.0 (#69) * added keyboard management to correctly scroll inside the text view (#71) * Rename "Dynamic Price" to "Dynamic" (#72) * Rename "Dynamic Price" for AdMob to "Dynamic" * Add rewardedInterstitial case for Admob * fixed video with/out UI settings (#73) * AdManagerViewController memory leak fix (#74) * fixed a memory leak where AdManagerViewController would never release, removed video settings singleton, reinstated setupCustomVideoSettings and resetVideoSettings() * removed redundant configuration * Update to 2.15.0 (#76) * fixes memory leaks - CustomAdContainerView doesn't need to hold a strong controller reference (#75) * passing optional header offset to fix use cases where container uses the exact ad dimensions (#77) * Updated Sample App to v2.15.1 (#78) * Removed pods from the project * Revert wrong change --------- Co-authored-by: Standa Musil <[email protected]> Co-authored-by: Inder Dhir <[email protected]> Co-authored-by: Standa Musil <[email protected]>
brugg
added a commit
that referenced
this pull request
Sep 5, 2023
* added cloning instructions (#56) * encryption declaration (#55) * added width/height constraints to fix the click action for manually rendered banner (#58) * Landscape improvements (#54) * different landscape ad sizes, adjusted constraints to improve the UI in landscape mode * helper renamed to nimbusIsLandscape * - Refactored settings using categorized enums - Event log is now hidden by default and can be configured via settings, it can also be toggled - Navigation bar is now hidden by default and can be toggled * - Logger padding - Animating top constraint instead of height of the headerView to avoid breaking constraints - Added headerOffset to other views that show ads * simplified using toggle() --------- Co-authored-by: Bruno Bruggemann <[email protected]> * Update Info.plist for DP rewarded id (#61) (#62) Co-authored-by: Inder Dhir <[email protected]> * Update Nimbus SDK to v2.13.0 (#63) * Admob changes develop (#66) * Add support for DP AdMob # Conflicts: # Application/Sources/Mediation/AdMob.swift * Update sample app for AdMob # Conflicts: # Application/Sources/Navigation.swift * Show relevant demos for AdMob/GAM * Show relevant demos for AdMob/GAM * Fix Admob impl * updated test renderer to trim white spaces and newlines, always render a static ad if the markup isn't a video (#67) * replaced test renderer's textField with a textView to allow scrolling and easier manipulation with the ad markup (#68) * Update Sample App to Nimbus v2.14.0 (#69) * added keyboard management to correctly scroll inside the text view (#71) * Rename "Dynamic Price" to "Dynamic" (#72) * Rename "Dynamic Price" for AdMob to "Dynamic" * Add rewardedInterstitial case for Admob * fixed video with/out UI settings (#73) * AdManagerViewController memory leak fix (#74) * fixed a memory leak where AdManagerViewController would never release, removed video settings singleton, reinstated setupCustomVideoSettings and resetVideoSettings() * removed redundant configuration * Update to 2.15.0 (#76) * fixes memory leaks - CustomAdContainerView doesn't need to hold a strong controller reference (#75) * passing optional header offset to fix use cases where container uses the exact ad dimensions (#77) * Updated Sample App to v2.15.1 (#78) * Removed pods from the project * Revert wrong change * Updated sample app to v2.15.2 (#80) --------- Co-authored-by: Standa Musil <[email protected]> Co-authored-by: Inder Dhir <[email protected]> Co-authored-by: Standa Musil <[email protected]>
brugg
added a commit
that referenced
this pull request
Sep 12, 2023
* added cloning instructions (#56) * encryption declaration (#55) * added width/height constraints to fix the click action for manually rendered banner (#58) * Landscape improvements (#54) * different landscape ad sizes, adjusted constraints to improve the UI in landscape mode * helper renamed to nimbusIsLandscape * - Refactored settings using categorized enums - Event log is now hidden by default and can be configured via settings, it can also be toggled - Navigation bar is now hidden by default and can be toggled * - Logger padding - Animating top constraint instead of height of the headerView to avoid breaking constraints - Added headerOffset to other views that show ads * simplified using toggle() --------- Co-authored-by: Bruno Bruggemann <[email protected]> * Update Info.plist for DP rewarded id (#61) (#62) Co-authored-by: Inder Dhir <[email protected]> * Update Nimbus SDK to v2.13.0 (#63) * Admob changes develop (#66) * Add support for DP AdMob # Conflicts: # Application/Sources/Mediation/AdMob.swift * Update sample app for AdMob # Conflicts: # Application/Sources/Navigation.swift * Show relevant demos for AdMob/GAM * Show relevant demos for AdMob/GAM * Fix Admob impl * updated test renderer to trim white spaces and newlines, always render a static ad if the markup isn't a video (#67) * replaced test renderer's textField with a textView to allow scrolling and easier manipulation with the ad markup (#68) * Update Sample App to Nimbus v2.14.0 (#69) * added keyboard management to correctly scroll inside the text view (#71) * Rename "Dynamic Price" to "Dynamic" (#72) * Rename "Dynamic Price" for AdMob to "Dynamic" * Add rewardedInterstitial case for Admob * fixed video with/out UI settings (#73) * AdManagerViewController memory leak fix (#74) * fixed a memory leak where AdManagerViewController would never release, removed video settings singleton, reinstated setupCustomVideoSettings and resetVideoSettings() * removed redundant configuration * Update to 2.15.0 (#76) * fixes memory leaks - CustomAdContainerView doesn't need to hold a strong controller reference (#75) * passing optional header offset to fix use cases where container uses the exact ad dimensions (#77) * Updated Sample App to v2.15.1 (#78) * Removed pods from the project * Revert wrong change * Updated sample app to v2.15.2 (#80) * Fix GAM bannerVideo unit not showing Nimbus banner (#83) * Updated to v2.15.3 * added a guide of how to switch between GAM and AdMob (#82) --------- Co-authored-by: Standa Musil <[email protected]> Co-authored-by: Inder Dhir <[email protected]> Co-authored-by: Standa Musil <[email protected]>
brugg
added a commit
that referenced
this pull request
Sep 28, 2023
* added cloning instructions (#56) * encryption declaration (#55) * added width/height constraints to fix the click action for manually rendered banner (#58) * Landscape improvements (#54) * different landscape ad sizes, adjusted constraints to improve the UI in landscape mode * helper renamed to nimbusIsLandscape * - Refactored settings using categorized enums - Event log is now hidden by default and can be configured via settings, it can also be toggled - Navigation bar is now hidden by default and can be toggled * - Logger padding - Animating top constraint instead of height of the headerView to avoid breaking constraints - Added headerOffset to other views that show ads * simplified using toggle() --------- Co-authored-by: Bruno Bruggemann <[email protected]> * Update Info.plist for DP rewarded id (#61) (#62) Co-authored-by: Inder Dhir <[email protected]> * Update Nimbus SDK to v2.13.0 (#63) * Admob changes develop (#66) * Add support for DP AdMob # Conflicts: # Application/Sources/Mediation/AdMob.swift * Update sample app for AdMob # Conflicts: # Application/Sources/Navigation.swift * Show relevant demos for AdMob/GAM * Show relevant demos for AdMob/GAM * Fix Admob impl * updated test renderer to trim white spaces and newlines, always render a static ad if the markup isn't a video (#67) * replaced test renderer's textField with a textView to allow scrolling and easier manipulation with the ad markup (#68) * Update Sample App to Nimbus v2.14.0 (#69) * added keyboard management to correctly scroll inside the text view (#71) * Rename "Dynamic Price" to "Dynamic" (#72) * Rename "Dynamic Price" for AdMob to "Dynamic" * Add rewardedInterstitial case for Admob * fixed video with/out UI settings (#73) * AdManagerViewController memory leak fix (#74) * fixed a memory leak where AdManagerViewController would never release, removed video settings singleton, reinstated setupCustomVideoSettings and resetVideoSettings() * removed redundant configuration * Update to 2.15.0 (#76) * fixes memory leaks - CustomAdContainerView doesn't need to hold a strong controller reference (#75) * passing optional header offset to fix use cases where container uses the exact ad dimensions (#77) * Updated Sample App to v2.15.1 (#78) * Removed pods from the project * Revert wrong change * Updated sample app to v2.15.2 (#80) * Fix GAM bannerVideo unit not showing Nimbus banner (#83) * Updated to v2.15.3 * added a guide of how to switch between GAM and AdMob (#82) * updated text for UI tests parity with android (#86) * added accessibility ID to test render textView (#88) * Add accessibility ID for video companion ad (#89) * internal unityGameId for reuse, added rawValue member to NavigationItem protocol to improve the navigation abstraction (#87) * Updated to v2.15.4 (#90) --------- Co-authored-by: Standa Musil <[email protected]> Co-authored-by: Inder Dhir <[email protected]> Co-authored-by: Standa Musil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.