chore: command orchestration #5791

TarunAdobe · 2025-10-07T09:24:13Z

Description

Added build-, test-, start-, and lint- root scripts so first- and second-gen workspaces can be orchestrated together.
Introduced a prebuild wireit target in first-gen/package.json that triggers the second-gen core build before the existing build pipeline.
Renamed the second-gen workspace to @adobe/swc and updated yarn.lock to reflect the new package name.

Motivation and context

Make the root package the single entry point for common dev workflows that span both generations of Spectrum Web Components.
Ensure first-gen builds automatically compile second-gen core artifacts to keep shared output in sync.

Related issue(s)

fixes [Issue Number]

Screenshots (if appropriate)

Author's checklist

I have read the CONTRIBUTING and PULL_REQUESTS documents.
I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
I have added automated tests to cover my changes.
I have included a well-written changeset if my change needs to be published.
I have included updated documentation if my change required it.

Reviewer's checklist

Includes a Github Issue with appropriate flag or Jira ticket number without a link
Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
Automated tests cover all use cases and follow best practices for writing
Validated on all supported browsers
All VRTs are approved before the author can update Golden Hash

Manual review test cases

Build Pipeline (First-gen and Second-gen)
- Test: Run yarn build at the repo root.
- Goal: Ensure both first-gen and second-gen workspaces build successfully and in the correct order.
- Check: No errors in the build output. Artifacts for both generations are correctly produced.
Test Scripts
- Test: Run yarn test, yarn test-first-gen, and yarn test-second-gen at the root.
- Goal: All tests in both generations (unit, integration, etc.) must pass.
- Check: Look for failures in either workspace.
Linting
- Test: Run yarn lint, yarn lint-first-gen, and yarn lint-second-gen.
- Goal: Linting completes without errors for both codebases.
- Check: Confirm the new shared ESLint config is applied and that there are no unexpected warnings or errors.
Wireit Integration
- Test: Run yarn workspace @adobe/spectrum-web-components build (or the specific first-gen build command).
- Goal: The new prebuild Wireit script should reliably trigger the second-gen build as a dependency.
- Check: No race conditions or missed dependencies; confirm that changes in second-gen core trigger rebuilds as expected.
CI/CD
- Test: Monitor all automated build and test jobs in your CI (e.g., GitHub Actions, Jenkins).
- Goal: All jobs pass after merging these changes.
- Check: Especially watch for any failures in composite builds or jobs that run the changed scripts.

Device review

Did it pass in Desktop?
Did it pass in (emulated) Mobile?
Did it pass in (emulated) iPad?

changeset-bot · 2025-10-07T09:24:17Z

⚠️ No Changeset found

Latest commit: 29f4e28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-10-07T09:26:27Z

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5791

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

github-actions · 2025-10-07T09:29:55Z

Tachometer results

Currently, no packages are changed by this PR...

rubencarvalho · 2025-10-14T10:51:21Z

first-gen/package.json

Would start also require yarn run dev on core?

second-gen/package.json

Rajdeepc · 2025-10-15T13:18:51Z

second-gen/package.json

    "scripts": {
-        "build": "yarn workspaces foreach --from '@swc/*' run build",
-        "clean": "yarn workspaces foreach --from '@swc/*' run clean",
+        "build": "yarn workspaces foreach --from '@swc/*' --recursive run build",


This will force Yarn to traverse downstream dependents, rebuilding or cleaning even when nothing changed. Is this what we need? We can do caching or parallelisation here too. Let me know your setup

Rajdeepc · 2025-10-15T13:19:38Z

second-gen/package.json

-        "build": "yarn workspaces foreach --from '@swc/*' run build",
-        "clean": "yarn workspaces foreach --from '@swc/*' run clean",
+        "build": "yarn workspaces foreach --from '@swc/*' --recursive run build",
+        "clean": "yarn workspaces foreach --from '@swc/*' --recursive run clean",


If you just want to delete the SWC output you can avoid the cascading clean. You can just run this?

yarn workspaces foreach --from '@swc/*' run clean

marissahuysentruyt · 2025-10-15T13:37:08Z

package.json

+        "build-first-gen": "yarn workspace @adobe/spectrum-web-components build",
+        "build-second-gen": "yarn workspace @adobe/swc build",
+        "build": "yarn build-first-gen && yarn build-second-gen",


This is strictly a curiosity I had: can you explain why you chose build-first-gen over something like build:first-gen? I've just seen the colon syntax more often, that's all.

Sort of along these lines, if we went with the colon syntax instead, could we do something like:

"build": "yarn build:*",

Why does the order of building first-gen or second-gen matter? I honestly don't know what order something like yarn build:* would build each project, so maybe this is not even a good idea or feasible! 😆

For the first part, It was an oversight on my end. I feel its better to use build:first-gen and so I switched that up. And about the second one, no the order of building first-gen or second-gen doesn't matter as long as both are being built before starting their respective storybooks.

marissahuysentruyt · 2025-10-15T18:42:35Z

Just wanted to leave some notes as I was walking through the validation steps.

For yarn build:
I am getting build errors (for second-gen), but they're not enough for me not to run either project. Were you getting those at all? 🤔 Maybe they're known or acceptable errors for now.

For yarn test:

the new first-gen and second-gen commands work from the root, and yarn test fires off both with no problems. 🥳

WireIt and workspace commands
First-gen and second-gen can be run with their corresponding Storybook start commands. 👍

For yarn lint:
For second-gen, I get the eslint command is not found error. First-gen I think is working- it output where I made changes correctly (to be honest, I don't remember what the output typically looks like for linting on main)

I don't think this is related to this PR or not, but when I run yarn build from the root (after running nvm use && git clean -dfX && yarn), I do get a message that Vite requires nvm version 20.19+, but our .nvmrc only has nvm at 20.13.1. Is that something we would want to address at some point?

…from next-gen

rubencarvalho · 2025-10-23T07:08:06Z

second-gen/packages/swc/package.json

+        "prestorybook": "cem analyze",
+        "storybook": "storybook dev -p 6006",
+        "storybook:build": "storybook build",
+        "test": "yarn workspace @swc/core dev & vitest",


This seems like "test:watch", is that accurate?

rubencarvalho · 2025-10-23T11:07:22Z

Some actions are not happy: https://github.com/adobe/spectrum-web-components/actions/runs/18699979041/job/53326445606?pr=5791
https://github.com/adobe/spectrum-web-components/actions/runs/18699979036/job/53326445593?pr=5791

caseyisonit · 2025-10-23T20:34:15Z

.eslintrc.json

+    ],
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "ecmaVersion": 2020,


Can we just use "latest" here or is there a reason we need to use "2020" version?

no reason. it was 2020 everywhere else so cursor copied the same thing and i didn't look. will update this to latest and see if nothing breaks

caseyisonit · 2025-10-23T21:41:40Z

package.json

+        "lint:first-gen": "yarn workspace @adobe/spectrum-web-components lint",
+        "lint:second-gen": "yarn workspace @adobe/swc lint",
+        "postinstall": "husky || true && patch-package",
+        "start": "yarn start:first-gen & yarn start:second-gen",


When running yarn start from the root directory, second-gen fails but first-gen will run. Screenshot of the error:

for some reason prestorybook hook was not getting called and thus this error.
i chained prestorybook explicitly to run before storybook in second-gen packages and it's working now

i was still getting the same error associated with storybook setup not having dirname correctly defined since we are using modules. i have implemented a fix and will push it up with my review.

package.json

caseyisonit · 2025-10-23T21:51:58Z

package.json

+        "lint": "yarn lint:first-gen && yarn lint:second-gen",
+        "lint:first-gen": "yarn workspace @adobe/spectrum-web-components lint",
+        "lint:second-gen": "yarn workspace @adobe/swc lint",
+        "postinstall": "husky || true && patch-package",


why do we need patch-package? we can patch packages with yarn4 now and have removed patch-package from first gen to my knowledge

great question but this is out of scope for the current PR. will track it on slack maybe?

rubencarvalho · 2025-10-24T10:44:08Z

second-gen/packages/swc/package.json

-        "prestorybook": "cem analyze",
-        "storybook": "storybook dev -p 6006",
-        "storybook:build": "storybook build",
+        "storybook": "yarn analyze && storybook dev -p 6006",


yarn cem:watch && storybook dev -p 6006?

rubencarvalho · 2025-10-24T10:44:38Z

second-gen/packages/swc/package.json

    "scripts": {
        "analyze": "cem analyze --config cem.config.js",
        "build": "vite build",
        "cem:watch": "cem analyze --watch",


nit, for consistency, could we do analyze:watch?

rubencarvalho · 2025-10-24T12:05:03Z

There’s a small issue: if Storybook for the first-generation package hasn’t been built yet, it won’t start successfully.
It’s possible that a dependency on the story decorators is missing.

Running yarn start:first-gen in that case shows this:

ERROR in ./storybook/preview.js 13:0-90
Module not found: Error: Can't resolve '@spectrum-web-components/story-decorator/decorator.js' in '/Users/ruben/Documents/Work/swc/first-gen/storybook'
 @ ./storybook-config-entry.js 10:1309-1382 40:2-43:4 40:1280-43:3

ERROR in ./storybook/preview.js 14:0-82
Module not found: Error: Can't resolve '@spectrum-web-components/story-decorator/src/locales.js' in '/Users/ruben/Documents/Work/swc/first-gen/storybook'
 @ ./storybook-config-entry.js 10:1309-1382 40:2-43:4 40:1280-43:3

ERROR in ./storybook/preview.js 17:0-72
Module not found: Error: Can't resolve '@spectrum-web-components/story-decorator/sp-story-decorator.js' in '/Users/ruben/Documents/Work/swc/first-gen/storybook'
 @ ./storybook-config-entry.js 10:1309-1382 40:2-43:4 40:1280-43:3

preview compiled with 3 errors
=> Failed to build the preview
<s> [webpack.Progress] 99% end closing watch compilation
<s> [webpack.Progress] 99% end closing watch compilation
WARN Force closed preview build
SB_BUILDER-WEBPACK5_0003 (WebpackCompilationError): There were problems when compiling your code with Webpack.
Run Storybook with --debug-webpack for more information.
    at starter (/Users/ruben/Documents/Work/swc/node_modules/@storybook/builder-webpack5/dist/index.js:1:24163)
    at starter.next (<anonymous>)
    at Module.start (/Users/ruben/Documents/Work/swc/node_modules/@storybook/builder-webpack5/dist/index.js:1:26142)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async storybookDevServer (/Users/ruben/Documents/Work/swc/node_modules/@storybook/core/dist/core-server/index.cjs:36423:79)
    at async buildOrThrow (/Users/ruben/Documents/Work/swc/node_modules/@storybook/core/dist/core-server/index.cjs:35049:12)
    at async buildDevStandalone (/Users/ruben/Documents/Work/swc/node_modules/@storybook/core/dist/core-server/index.cjs:37628:78)
    at async withTelemetry (/Users/ruben/Documents/Work/swc/node_modules/@storybook/core/dist/core-server/index.cjs:35788:12)
    at async dev (/Users/ruben/Documents/Work/swc/node_modules/@storybook/core/dist/cli/bin/index.cjs:5874:3)
    at async s.<anonymous> (/Users/ruben/Documents/Work/swc/node_modules/@storybook/core/dist/cli/bin/index.cjs:6052:74)
⠇
WARN Broken build, fix the error above.
 You may need to refresh the browser.

caseyisonit · 2025-10-24T17:55:41Z

second-gen/.eslintrc.json

        "lit-a11y/click-events-have-key-events": [
            "error",
            {
                "allowList": [


Why are we including this in second gen? this is very much a first-gen pattern.

not necessarily a part of this pr bt good catch. I shall remove this

caseyisonit · 2025-10-24T17:57:01Z

second-gen/.eslintrc.json

Can we make sure to review the linter settings we want in second-gen to ensure they are patterns we want to continue using or add new ones? This is not blocking for this PR but want to make sure we discuss as a team

cc @rubencarvalho @graynorton

What currently is here is just a simple setup to get eslinting up and running. We can and should talk about it :)

caseyisonit · 2025-10-24T17:57:50Z

second-gen/.eslintrc.json

            }
        ],
        "no-debugger": 2,
-        "notice/notice": [


we need to make sure this is still working in second gen, we should still be prepending a copywright to every file.

Why was this removed?

Does the root level work across the project?

I removed it cause we don't have a license.js config for second-gen and i don't know if we want to replicate the first-gen or not?

We do, yes. License should be project-wide

rubencarvalho

gut gut!!

caseyisonit

crushed it

chore: hoist dev commands to root packagejson

3cd08a9

TarunAdobe changed the title ~~chore: hoist dev commands to root packagejson~~ chore: command orchestration Oct 7, 2025

TarunAdobe marked this pull request as ready for review October 8, 2025 05:54

TarunAdobe requested a review from a team as a code owner October 8, 2025 05:54

TarunAdobe self-assigned this Oct 8, 2025

TarunAdobe requested a review from rubencarvalho October 8, 2025 05:54

chore: add a root level eslint config file

ffa43cc

rubencarvalho reviewed Oct 14, 2025

View reviewed changes

first-gen/package.json

Copy link

Contributor

rubencarvalho Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would start also require yarn run dev on core?

TarunAdobe reacted with thumbs up emoji

rubencarvalho reviewed Oct 14, 2025

View reviewed changes

second-gen/package.json Outdated Show resolved Hide resolved

Rajdeepc reviewed Oct 15, 2025

View reviewed changes

marissahuysentruyt reviewed Oct 15, 2025

View reviewed changes

TarunAdobe added 3 commits October 16, 2025 14:32

fix(progress-circle): remove @spectrum-web-component/base dependency …

1e00ab5

…from next-gen

chore: update build commands in root packagejson

1f1e69e

chore: run hmr on core for storybook and test

c57c437

TarunAdobe requested a review from rubencarvalho October 17, 2025 12:22

caseyisonit added 2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. Status: Ready for review PR ready for review or re-review. labels Oct 20, 2025

rubencarvalho and others added 2 commits October 21, 2025 18:03

Merge branch 'barebones' into ttomar/command-orchestration

b5ee171

Merge branch 'barebones' into ttomar/command-orchestration

0107b93

rubencarvalho reviewed Oct 23, 2025

View reviewed changes

chore: fix test command in second-gen and add eslint dev dependency

85e914c

TarunAdobe force-pushed the ttomar/command-orchestration branch from ff96761 to 85e914c Compare October 23, 2025 11:40

TarunAdobe requested review from marissahuysentruyt and rubencarvalho October 23, 2025 11:56

rubencarvalho mentioned this pull request Oct 23, 2025

chore(deps): pin package dependencies in 2nd-gen #5820

Merged

13 tasks

caseyisonit reviewed Oct 23, 2025

View reviewed changes

package.json Show resolved Hide resolved

caseyisonit reviewed Oct 23, 2025

View reviewed changes

chore: explicitly run prestorybook in second-gen

1b9f9d0

TarunAdobe force-pushed the ttomar/command-orchestration branch from abce0f2 to 1b9f9d0 Compare October 24, 2025 09:07

TarunAdobe requested a review from caseyisonit October 24, 2025 10:02

rubencarvalho reviewed Oct 24, 2025

View reviewed changes

chore: update cem analyze command

689ffcc

TarunAdobe and others added 2 commits October 24, 2025 19:14

chore: build ts before storybook in first-gen

0ee20d4

Merge branch 'barebones' into ttomar/command-orchestration

fce826e

caseyisonit reviewed Oct 24, 2025

View reviewed changes

caseyisonit added the High priority PR review PR is a high priority and should be reviewed ASAP label Oct 24, 2025

chore: hoist license eslint rule to top

29f4e28

TarunAdobe force-pushed the ttomar/command-orchestration branch from 6f57fd4 to 29f4e28 Compare October 27, 2025 11:09

rubencarvalho approved these changes Oct 27, 2025

View reviewed changes

TarunAdobe requested a review from caseyisonit October 27, 2025 13:54

caseyisonit approved these changes Oct 27, 2025

View reviewed changes

caseyisonit merged commit 502ffc8 into barebones Oct 27, 2025
22 checks passed

caseyisonit deleted the ttomar/command-orchestration branch October 27, 2025 20:29

chore: command orchestration #5791

chore: command orchestration #5791

Uh oh!

Conversation

TarunAdobe commented Oct 7, 2025 • edited by Rajdeepc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and context

Related issue(s)

Screenshots (if appropriate)

Author's checklist

Reviewer's checklist

Manual review test cases

Device review

Uh oh!

changeset-bot bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📚 Branch Preview

🔍 Visual Regression Test Results

Uh oh!

github-actions bot commented Oct 7, 2025

Tachometer results

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marissahuysentruyt Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marissahuysentruyt commented Oct 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rubencarvalho commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

caseyisonit Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rubencarvalho commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

TarunAdobe commented Oct 7, 2025 •

edited by Rajdeepc

Loading

changeset-bot bot commented Oct 7, 2025 •

edited

Loading

github-actions bot commented Oct 7, 2025 •

edited

Loading

marissahuysentruyt Oct 15, 2025 •

edited

Loading

rubencarvalho commented Oct 23, 2025 •

edited

Loading

caseyisonit Oct 23, 2025 •

edited

Loading

rubencarvalho commented Oct 24, 2025 •

edited

Loading