Skip to content

chore: command orchestration #5791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 27, 2025
Merged

chore: command orchestration #5791

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3cd08a9
chore: hoist dev commands to root packagejson
TarunAdobe Oct 7, 2025
ffa43cc
chore: add a root level eslint config file
TarunAdobe Oct 8, 2025
1e00ab5
fix(progress-circle): remove @spectrum-web-component/base dependency …
TarunAdobe Oct 16, 2025
1f1e69e
chore: update build commands in root packagejson
TarunAdobe Oct 16, 2025
c57c437
chore: run hmr on core for storybook and test
TarunAdobe Oct 17, 2025
b5ee171
Merge branch 'barebones' into ttomar/command-orchestration
rubencarvalho Oct 21, 2025
0107b93
Merge branch 'barebones' into ttomar/command-orchestration
caseyisonit Oct 21, 2025
85e914c
chore: fix test command in second-gen and add eslint dev dependency
TarunAdobe Oct 23, 2025
1b9f9d0
chore: explicitly run prestorybook in second-gen
TarunAdobe Oct 24, 2025
689ffcc
chore: update cem analyze command
TarunAdobe Oct 24, 2025
0ee20d4
chore: build ts before storybook in first-gen
TarunAdobe Oct 24, 2025
fce826e
Merge branch 'barebones' into ttomar/command-orchestration
rubencarvalho Oct 24, 2025
29f4e28
chore: hoist license eslint rule to top
TarunAdobe Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 2020,
"ecmaVersion": "latest",
"sourceType": "module"
},
"plugins": ["@typescript-eslint"],
Expand Down
2 changes: 1 addition & 1 deletion first-gen/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 2020,
"ecmaVersion": "latest",
"sourceType": "module"
},
"plugins": [
Expand Down
2 changes: 1 addition & 1 deletion second-gen/.eslintrc.json
View file
Open in desktop
Copy link
Contributor

@caseyisonit caseyisonit Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure to review the linter settings we want in second-gen to ensure they are patterns we want to continue using or add new ones? This is not blocking for this PR but want to make sure we discuss as a team

cc @rubencarvalho @graynorton

Copy link
Contributor

@rubencarvalho rubencarvalho Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What currently is here is just a simple setup to get eslinting up and running. We can and should talk about it :)

Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 2020,
"ecmaVersion": "latest",
"sourceType": "module"
},
"plugins": [
Expand Down
7 changes: 3 additions & 4 deletions second-gen/packages/swc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@
"cem:watch": "cem analyze --watch",
Copy link
Contributor

@rubencarvalho rubencarvalho Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, for consistency, could we do analyze:watch?

"clean": "rimraf dist",
"dev": "vite build --watch",
"prestorybook": "cem analyze",
"storybook": "storybook dev -p 6006",
"storybook:build": "storybook build",
"storybook": "yarn analyze && storybook dev -p 6006",
Copy link
Contributor

@rubencarvalho rubencarvalho Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn cem:watch && storybook dev -p 6006?

"storybook:build": "yarn analyze && storybook build",
"test": "vitest --run",
"test:coverage": "vitest --coverage",
"test:ui": "vitest --ui",
Expand Down Expand Up @@ -92,5 +91,5 @@
"engines": {
"node": ">=20"
},
"customElements": "custom-elements.json"
"customElements": ".storybook/custom-elements.json"
}
Loading