Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Internal Review) add debug logging to resource auto-detection #1

Closed
wants to merge 62 commits into from
Closed

(Internal Review) add debug logging to resource auto-detection #1

wants to merge 62 commits into from

Conversation

adamegyed
Copy link
Owner

Signed-off-by: Adam Egyed [email protected]

Which problem is this PR solving?

Short description of the changes

  • Added ResourceDetectionConfig interface to be optionally taken in by the detectResources function. Currently only configurable field is logger, which takes in a function to be used as debug log for resource auto-detection.
  • Added unit tests for logger functionality

renovate-bot and others added 12 commits June 13, 2020 11:50
@renovate-bot
chore(deps): pin dependencies (open-telemetry#1194)
9d58227
@markwolff
refactor(attributes): move enums to @opentelemetry/semantic-conventio…
0596054 
…ns (open-telemetry#1160)
@renovate-bot
chore(deps): update dependency sinon to v9 (open-telemetry#1196)
87882cb
@mayurkale22 @dyladan
Add @legendecas to approvers / CODEOWNERS (open-telemetry#1198)
56a2413 
Co-authored-by: Daniel Dyla <[email protected]>
@renovate-bot
chore(deps): update typescript-eslint monorepo to v3.3.0 (open-teleme…
fd5c142 
…try#1199)
@renovate-bot
chore(deps): update dependency typescript to v3.9.5 (open-telemetry#1195
b20bbf9 
)
@davidwitten @mayurkale22
fix(exporter-collector): default endpoint for node and browser (open-…
deb3570 
…telemetry#1197)

Co-authored-by: Mayur Kale <[email protected]>
@adamegyed
feat: add debug logging to resource auto-detection
07f0e0e 
Signed-off-by: Adam Egyed <[email protected]>
@obecny @mayurkale22 @dyladan
chore: adding plugin-fetch and example (open-telemetry#1121)
0d939d2 
* chore: adding plugin-fetch and example

* chore: investigating failing test

* chore: chore fixing tests with better fetch mocking

* chore: addressing comments

* chore: lint

* chore: addressing comments

* chore: updating webpack-env

* chore: fixes after update for node types

* chore: addressing reviews

* chore: fixes after merge

* chore: updating version

Co-authored-by: Mayur Kale <[email protected]>
Co-authored-by: Daniel Dyla <[email protected]>
@renovate-bot
chore(deps): pin dependencies (open-telemetry#1205)
744c871
@dyladan
feat: add node-plugins-all package (open-telemetry#1181)
a2d1964
@adamegyed
refactor: change resource detection to use logger from opentelemetry-api
f0486e7 
Signed-off-by: Adam Egyed <[email protected]>
@adamegyed adamegyed force-pushed the ResourceAutoDetectionLogging branch from 0bccc3f to f0486e7 Compare June 17, 2020 21:13
@adamegyed
Copy link
Owner Author

Note: This is a separate PR not intended for review by OpenTelemetry contributors. That PR can be found at open-telemetry#1211

@adamegyed adamegyed changed the title feat: add debug logging to resource auto-detection (Internal Review) add debug logging to resource auto-detection Jun 17, 2020
renovate-bot and others added 7 commits June 17, 2020 22:21
@renovate-bot
fix(deps): pin dependencies (open-telemetry#1212)
7afc454
@mwear @mayurkale22
feat: collector exporter custom headers and metadata (open-telemetry#…
28ad2ce 
…1204)

Co-authored-by: Mayur Kale <[email protected]>
@obecny @mayurkale22
chore: fixing zone from which to fork a new zone (open-telemetry#1209)
2486c3d 
* chore: fixing zone from which to fork a new zone

* chore: adding tests for creating zone

Co-authored-by: Mayur Kale <[email protected]>
@dyladan
chore: fix markdown linting and add npm script (open-telemetry#1217)
f9f5df5
@obecny @dyladan @mayurkale22
Adds possibility to set headers to zipkin exporter (open-telemetry#1202)
2afaffa 
Co-authored-by: Daniel Dyla <[email protected]>
Co-authored-by: Mayur Kale <[email protected]>
@mayurkale22
chore: 0.9.0 release proposal (open-telemetry#1208)
904245f
@adamegyed
refactor: separated logging of resources from detection method
4372c80 
Signed-off-by: Adam Egyed <[email protected]>
@adamegyed adamegyed force-pushed the ResourceAutoDetectionLogging branch from e81575b to 4372c80 Compare June 19, 2020 00:15
@lunajrq
Copy link

lunajrq commented Jun 22, 2020

LGTM

markwolff and others added 29 commits June 24, 2020 09:57
@markwolff @mayurkale22
fix(package.json): publish source maps (open-telemetry#1237)
153169a 
Co-authored-by: Mayur Kale <[email protected]>
@renovate-bot @mayurkale22
chore(deps): update dependency gh-pages to v3.1.0 (open-telemetry#1227)
7ac8c3a 
Co-authored-by: Mayur Kale <[email protected]>
@renovate-bot @dyladan
chore(deps): update typescript-eslint monorepo to v3.4.0 (open-teleme…
bd95884 
…try#1232)

Co-authored-by: Daniel Dyla <[email protected]>
@renovate-bot @mayurkale22
chore(deps): update dependency @types/jquery to v3.5.0 (open-telemetr…
68f630d 
…y#1229)

Co-authored-by: Mayur Kale <[email protected]>
@renovate-bot @mayurkale22
chore(deps): update dependency @babel/core to v7.10.3 (open-telemetry…
70794d7 
…#1224)

Co-authored-by: Mayur Kale <[email protected]>
@mayurkale22
Nominate @obecny as maintainer (open-telemetry#1243)
dbe2e72
@adamegyed
feat: added debug logging to each resource detector
e0e9583
@renovate-bot @mayurkale22
chore(deps): update dependency eslint to v7.3.1 (open-telemetry#1225)
0788609 
Co-authored-by: Mayur Kale <[email protected]>
@renovate-bot
chore(deps): update dependency @types/node to v14.0.14 (open-telemetr…
bff0b66 
…y#1244)
@renovate-bot
chore(deps): update dependency @types/semver to v7.3.1 (open-telemetr…
643b97f 
…y#1245)
@adamegyed
refactor: resource detection config reorganized
3c7aa9c 
Signed-off-by: Adam Egyed <[email protected]>
@johanneswuerbach @dyladan
AsyncLocalStorage based ContextManager (open-telemetry#1210)
bf2f617 
Co-authored-by: Daniel Dyla <[email protected]>
@adamegyed
fix: removed default parameter from detectors
665fb66 
Signed-off-by: Adam Egyed <[email protected]>
@adamegyed
chore: add tsdoc comments
6140c2e 
Signed-off-by: Adam Egyed <[email protected]>
@adamegyed
fix: logger typo
afd3e08 
Signed-off-by: Adam Egyed <[email protected]>
@adamegyed
fix: adjust typo in unit test
8c2a95e 
Signed-off-by: Adam Egyed <[email protected]>
@adamegyed
Merge branch 'master' into ResourceAutoDetectionLogging
23a22c2
@obecny @mayurkale22
Add platform agnostic way to read environment variables (open-telemet…
e19a0db 
…ry#1191)

Co-authored-by: Mayur Kale <[email protected]>
@mayurkale22
update renovate rules (open-telemetry#1246)
d738a82
@adamegyed
Merge branch 'master' into ResourceAutoDetectionLogging
f289a49
@mayurkale22 @dyladan
chore: update metrics example with UpDownCounter (open-telemetry#1239)
4e61459 
* chore: update metrics example with UpDownCounter

* chore: update getting-started

* chore: update README

* fix: lint

* Update packages/opentelemetry-metrics/README.md

Co-authored-by: Daniel Dyla <[email protected]>

* Update packages/opentelemetry-metrics/README.md

Co-authored-by: Daniel Dyla <[email protected]>

Co-authored-by: Daniel Dyla <[email protected]>
@mayurkale22 @dyladan
fix: renovate config (open-telemetry#1251)
336286a 
Co-authored-by: Daniel Dyla <[email protected]>
@davidwitten
feat: [Collector Metric Exporter][1/x] Rename CollectorExporter to Co…
a370a47 
…llectorTraceExporter (open-telemetry#1256)
@mayurkale22
Remove @rochdev from @open-telemetry/js-approvers (open-telemetry#1257)
74a9e2c
@jufab @mayurkale22
fix: default url for otelcol (open-telemetry#1254)
5aa851a 
* fix: default url for otelcol

* docs: review example from default url otelcol

Co-authored-by: Mayur Kale <[email protected]>
@obecny
Batch observer (open-telemetry#1137)
9845b4f 
* chore: adding batch observer, some metrics refactoring

* chore: undo changes after testing

* chore: undo changes after testing

* chore: addressing comments

* chore: renaming observer into value observer, fixing few spotted issues

* chore: missing renamed for ValueObserver

* chore: removing unused class

* chore: cleanup

* chore: refactoring, renaming aggregators

* chore: refactoring observer to have base class that can be extended

* chore: changing aggregator for ValueObserver, exposing batcher so it can be used to override a default one

* chore: addressing comments

* chore: addressing comments

* chore: preventing user from updating observer after timeout or update

* chore: aligning aggregators for value observer and recorder with regards to last spec changes

* chore: fixing test

* chore: fixes after merge

* chore: changes after review

* chore: changes after review with some additional fixes around typing

* chore: changes after review

* chore: lint

* chore: reviews

* chore: typo
@dyladan
Merge branch 'master' into ResourceAutoDetectionLogging
e612d5c
@mayurkale22
Remove @bg451 from @open-telemetry/js-approvers (open-telemetry#1264)
ac7dc6d
@mayurkale22
Merge branch 'master' into ResourceAutoDetectionLogging
2bc0b82
@adamegyed adamegyed closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.