chore: adding plugin-fetch and example #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
mwear,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
+ Coverage 92.16% 92.32% +0.16%
==========================================
Files 120 122 +2
Lines 3409 3533 +124
Branches 696 714 +18
==========================================
+ Hits 3142 3262 +120
- Misses 267 271 +4
|
dyladan
reviewed
May 28, 2020
| /** | ||
| * https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md | ||
| */ | ||
| export enum AttributeNames { |
There was a problem hiding this comment.
I wonder if we should have a package just for semantic convention constants and possibly even builder classes. Not really an issue for this PR, just a thought
There was a problem hiding this comment.
they could be a part of core or maybe even an api
dyladan
reviewed
May 28, 2020
andrewhsu
approved these changes
Jun 2, 2020
|
@open-telemetry/javascript-approvers @open-telemetry/javascript-maintainers |
markwolff
reviewed
Jun 8, 2020
mayurkale22
reviewed
Jun 9, 2020
|
Added a few minor comments in the first pass. |
dyladan
approved these changes
Jun 9, 2020
mayurkale22
approved these changes
Jun 13, 2020
vmarchaud
approved these changes
Jun 13, 2020
dyladan
added
the
Merge:LGTM
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* chore: adding plugin-fetch and example * chore: investigating failing test * chore: chore fixing tests with better fetch mocking * chore: addressing comments * chore: lint * chore: addressing comments * chore: updating webpack-env * chore: fixes after update for node types * chore: addressing reviews * chore: fixes after merge * chore: updating version Co-authored-by: Mayur Kale <[email protected]> Co-authored-by: Daniel Dyla <[email protected]>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* chore: adding plugin-fetch and example * chore: investigating failing test * chore: chore fixing tests with better fetch mocking * chore: addressing comments * chore: lint * chore: addressing comments * chore: updating webpack-env * chore: fixes after update for node types * chore: addressing reviews * chore: fixes after merge * chore: updating version Co-authored-by: Mayur Kale <[email protected]> Co-authored-by: Daniel Dyla <[email protected]>
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes