Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to Resource detection #920

Closed
mwear opened this issue Apr 1, 2020 · 1 comment · Fixed by #1211
Closed

Add logging to Resource detection #920

mwear opened this issue Apr 1, 2020 · 1 comment · Fixed by #1211
Assignees
Labels

Comments

@mwear
Copy link
Member

mwear commented Apr 1, 2020

Is your feature request related to a problem? Please describe.
Resource auto-detection is great when it works, but hard to debug when it doesn't. Having an option to turn on debug logging will help figure out what Resources were detected, and what data the detectors received.

Describe the solution you'd like
Pass a logger, or perhaps a ResourceDetectionConfig object with a logger into the detectResources method. Log at debug level if a Resource was detected, and the data discovered during the detection.

Describe alternatives you've considered
Open to any other reasonable approaches.

@adamegyed
Copy link
Contributor

Hi, I'm a Google Intern looking to start contributing to OpenTelemetry. Could I be assigned to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants